@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clarify that the "Add Comment" button might not literally add a comment if you haven't typed a comment
Summary: Ref T9908.
Test Plan: Careful reading.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9908
Differential Revision: https://secure.phabricator.com/D14746
+35
-14
+4
-5
src/applications/maniphest/editor/ManiphestEditEngine.php
+4
-5
src/applications/maniphest/editor/ManiphestEditEngine.php
···
42
42
}
43
43
44
44
protected function getCommentViewHeaderText($object) {
45
-
$is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');
46
-
if (!$is_serious) {
47
-
return pht('Weigh In');
48
-
}
45
+
return pht('Weigh In');
46
+
}
49
47
50
-
return parent::getCommentViewHeaderText($object);
48
+
protected function getCommentViewButtonText($object) {
49
+
return pht('Set Sail for Adventure');
51
50
}
52
51
53
52
protected function getObjectViewURI($object) {
+4
-5
src/applications/paste/editor/PhabricatorPasteEditEngine.php
+4
-5
src/applications/paste/editor/PhabricatorPasteEditEngine.php
···
39
39
}
40
40
41
41
protected function getCommentViewHeaderText($object) {
42
-
$is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');
43
-
if (!$is_serious) {
44
-
return pht('Eat Paste');
45
-
}
42
+
return pht('Eat Paste');
43
+
}
46
44
47
-
return parent::getCommentViewHeaderText($object);
45
+
protected function getCommentViewButtonText($object) {
46
+
return pht('Nom Nom Nom Nom Nom');
48
47
}
49
48
50
49
protected function getObjectViewURI($object) {
+27
-4
src/applications/transactions/editengine/PhabricatorEditEngine.php
+27
-4
src/applications/transactions/editengine/PhabricatorEditEngine.php
···
172
172
/**
173
173
* @task text
174
174
*/
175
+
protected function getCommentViewSeriousHeaderText($object) {
176
+
return pht('Take Action');
177
+
}
178
+
179
+
180
+
/**
181
+
* @task text
182
+
*/
183
+
protected function getCommentViewSeriousButtonText($object) {
184
+
return pht('Submit');
185
+
}
186
+
187
+
188
+
/**
189
+
* @task text
190
+
*/
175
191
protected function getCommentViewHeaderText($object) {
176
-
return pht('Add Comment');
192
+
return $this->getCommentViewSeriousHeaderText($object);
177
193
}
178
194
179
195
···
181
197
* @task text
182
198
*/
183
199
protected function getCommentViewButtonText($object) {
184
-
return pht('Add Comment');
200
+
return $this->getCommentViewSeriousButtonText($object);
185
201
}
186
202
187
203
···
1125
1141
$viewer = $this->getViewer();
1126
1142
$object_phid = $object->getPHID();
1127
1143
1128
-
$header_text = $this->getCommentViewHeaderText($object);
1129
-
$button_text = $this->getCommentViewButtonText($object);
1144
+
$is_serious = PhabricatorEnv::getEnvConfig('phabricator.serious-business');
1145
+
1146
+
if ($is_serious) {
1147
+
$header_text = $this->getCommentViewSeriousHeaderText($object);
1148
+
$button_text = $this->getCommentViewSeriousButtonText($object);
1149
+
} else {
1150
+
$header_text = $this->getCommentViewHeaderText($object);
1151
+
$button_text = $this->getCommentViewButtonText($object);
1152
+
}
1130
1153
1131
1154
$comment_uri = $this->getEditURI($object, 'comment/');
1132
1155