@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make an old migration a little more robust
Summary: See https://github.com/facebook/phabricator/pull/507
Test Plan: This is hard to test since the migration no longer runs against HEAD, but pull 507 strongly implies this is the correct fix.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D8837
+7
+7
resources/sql/patches/20131004.dxreviewers.php
+7
resources/sql/patches/20131004.dxreviewers.php
···
29
29
->setActor(PhabricatorUser::getOmnipotentUser());
30
30
31
31
foreach ($reviewer_phids as $dst) {
32
+
if (phid_get_type($dst) == PhabricatorPHIDConstants::PHID_TYPE_UNKNOWN) {
33
+
// At least one old install ran into some issues here. Skip the row if we
34
+
// can't figure out what the destination PHID is. See here:
35
+
// https://github.com/facebook/phabricator/pull/507
36
+
continue;
37
+
}
38
+
32
39
$editor->addEdge(
33
40
$revision_phid,
34
41
PhabricatorEdgeConfig::TYPE_DREV_HAS_REVIEWER,