@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Clean up a PhutilURI "alter()" callsite in Diffusion blame
Summary: See <https://discourse.phabricator-community.org/t/exception-when-viewing-previous-revision-from-blame/2454/2>.
Test Plan: Viewed blame, clicked "Skip Past This Commit". Got jumped to the right place instead of a URI exception.
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D20222
+11
-2
+11
-2
src/applications/diffusion/controller/DiffusionBrowseController.php
+11
-2
src/applications/diffusion/controller/DiffusionBrowseController.php
···
709
709
'path' => $path,
710
710
));
711
711
712
-
$before_uri = $before_uri->alter('renamed', $renamed);
713
-
$before_uri = $before_uri->alter('follow', $follow);
712
+
if ($renamed === null) {
713
+
$before_uri->removeQueryParam('renamed');
714
+
} else {
715
+
$before_uri->replaceQueryParam('renamed', $renamed);
716
+
}
717
+
718
+
if ($follow === null) {
719
+
$before_uri->removeQueryParam('follow');
720
+
} else {
721
+
$before_uri->replaceQueryParam('follow', $follow);
722
+
}
714
723
715
724
return id(new AphrontRedirectResponse())->setURI($before_uri);
716
725
}