@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Improve commit audit status icons
Summary:
Ref T9482. These may need a little more work (feel free to shoot me a counter-diff) but try to:
- Never use only color to distinguish between states (for colorblind, etc users).
- Give the "nothing needs to be done" state a more obvious "okay" icon (instead of a question mark).
Test Plan: Looked at some linked commits in Maniphest, the icons made a bit more sense?
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9482
Differential Revision: https://secure.phabricator.com/D17203
+11
-3
+11
-3
src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php
+11
-3
src/applications/audit/constants/PhabricatorAuditCommitStatusConstants.php
···
10
10
11
11
public static function getStatusNameMap() {
12
12
$map = array(
13
-
self::NONE => pht('None'),
13
+
self::NONE => pht('No Audits'),
14
14
self::NEEDS_AUDIT => pht('Audit Required'),
15
15
self::CONCERN_RAISED => pht('Concern Raised'),
16
16
self::PARTIALLY_AUDITED => pht('Partially Audited'),
···
46
46
case self::FULLY_AUDITED:
47
47
$color = 'green';
48
48
break;
49
+
case self::NONE:
50
+
$color = 'bluegrey';
51
+
break;
49
52
default:
50
53
$color = null;
51
54
break;
···
56
59
public static function getStatusIcon($code) {
57
60
switch ($code) {
58
61
case self::CONCERN_RAISED:
59
-
$icon = 'fa-exclamation-circle';
62
+
$icon = 'fa-times-circle';
60
63
break;
61
64
case self::NEEDS_AUDIT:
62
-
case self::PARTIALLY_AUDITED:
63
65
$icon = 'fa-exclamation-circle';
64
66
break;
67
+
case self::PARTIALLY_AUDITED:
68
+
$icon = 'fa-check-circle-o';
69
+
break;
65
70
case self::FULLY_AUDITED:
71
+
$icon = 'fa-check-circle';
72
+
break;
73
+
case self::NONE:
66
74
$icon = 'fa-check';
67
75
break;
68
76
default: