@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Skip Conduit call log writes in read-only mode, allowing "conduit.ping" to run
Summary: Ref T10769. See PHI8. We have an unconditional logging write which we can skip in read-only mode.
Test Plan:
- Put Phabricator in read-only mode with `cluster.read-only`.
- Called `conduit.ping` via web UI.
- Before: write-on-read-only exception.
- After: good result.
Reviewers: chad, amckinley
Reviewed By: chad
Maniphest Tasks: T10769
Differential Revision: https://secure.phabricator.com/D18233
+5
-3
+5
-3
src/applications/conduit/controller/PhabricatorConduitAPIController.php
+5
-3
src/applications/conduit/controller/PhabricatorConduitAPIController.php
···
119
119
->setError((string)$error_code)
120
120
->setDuration(1000000 * ($time_end - $time_start));
121
121
122
-
$unguarded = AphrontWriteGuard::beginScopedUnguardedWrites();
123
-
$log->save();
124
-
unset($unguarded);
122
+
if (!PhabricatorEnv::isReadOnly()) {
123
+
$unguarded = AphrontWriteGuard::beginScopedUnguardedWrites();
124
+
$log->save();
125
+
unset($unguarded);
126
+
}
125
127
126
128
$response = id(new ConduitAPIResponse())
127
129
->setResult($result)