+1 -1

src/applications/remarkup/conduit/RemarkupProcessConduitAPIMethod.php

reviewed

··· 11 11 } 12 12 13 13 public function getMethodDescription() { 14 14 - return pht('Process text through remarkup in Phabricator context.'); 14 14 + return pht('Process text through remarkup.'); 15 15 } 16 16 17 17 protected function defineReturnType() {

+1 -1

src/applications/repository/engine/PhabricatorRepositoryMirrorEngine.php

reviewed

··· 16 16 17 17 if (PhabricatorEnv::getEnvConfig('phabricator.silent')) { 18 18 $this->log( 19 19 - pht('Phabricator is running in silent mode; declining to mirror.')); 19 19 + pht('This software is running in silent mode; declining to mirror.')); 20 20 return; 21 21 } 22 22

+1 -1

src/applications/repository/management/PhabricatorRepositoryManagementCacheWorkflow.php

reviewed

··· 47 47 ->loadPathIDs(); 48 48 if (empty($path_map[$path_name])) { 49 49 throw new PhutilArgumentUsageException( 50 50 - pht('Path "%s" is not known to Phabricator.', $path_name)); 50 50 + pht('Path "%s" is not unknown.', $path_name)); 51 51 } 52 52 $path_id = $path_map[$path_name]; 53 53

+2 -1

src/applications/repository/storage/PhabricatorRepository.php

reviewed

··· 203 203 204 204 public function getDisplayName() { 205 205 $slug = $this->getRepositorySlug(); 206 206 - if (strlen($slug)) { 206 206 + 207 207 + if (phutil_nonempty_string($slug)) { 207 208 return $slug; 208 209 } 209 210

+2 -2

src/applications/repository/storage/PhabricatorRepositoryCommit.php

reviewed

··· 674 674 return array( 675 675 'buildable.commit' => pht('The commit identifier, if applicable.'), 676 676 'repository.callsign' => 677 677 - pht('The callsign of the repository in Phabricator.'), 677 677 + pht('The callsign of the repository.'), 678 678 'repository.phid' => 679 679 - pht('The PHID of the repository in Phabricator.'), 679 679 + pht('The PHID of the repository.'), 680 680 'repository.vcs' => 681 681 pht('The version control system, either "svn", "hg" or "git".'), 682 682 'repository.uri' =>

+5 -7

src/applications/repository/storage/PhabricatorRepositoryURI.php

reviewed

··· 501 501 'color' => 'green', 502 502 'label' => pht('Observe'), 503 503 'note' => pht( 504 504 - 'Phabricator will observe changes to this URI and copy them.'), 504 504 + 'Changes to this URI will be observed and pulled.'), 505 505 'short' => pht('Copy from a remote.'), 506 506 ), 507 507 self::IO_MIRROR => array( ··· 509 509 'color' => 'green', 510 510 'label' => pht('Mirror'), 511 511 'note' => pht( 512 512 - 'Phabricator will push a copy of any changes to this URI.'), 512 512 + 'A copy of any changes will be pushed to this URI.'), 513 513 'short' => pht('Push a copy to a remote.'), 514 514 ), 515 515 self::IO_NONE => array( ··· 517 517 'color' => 'grey', 518 518 'label' => pht('No I/O'), 519 519 'note' => pht( 520 520 - 'Phabricator will not push or pull any changes to this URI.'), 520 520 + 'No changes will be pushed or pulled from this URI.'), 521 521 'short' => pht('Do not perform any I/O.'), 522 522 ), 523 523 self::IO_READ => array( ··· 525 525 'color' => 'blue', 526 526 'label' => pht('Read Only'), 527 527 'note' => pht( 528 528 - 'Phabricator will serve a read-only copy of the repository from '. 529 529 - 'this URI.'), 528 528 + 'A read-only copy of the repository will be served from this URI.'), 530 529 'short' => pht('Serve repository in read-only mode.'), 531 530 ), 532 531 self::IO_READWRITE => array( ··· 534 533 'color' => 'blue', 535 534 'label' => pht('Read/Write'), 536 535 'note' => pht( 537 537 - 'Phabricator will serve a read/write copy of the repository from '. 538 538 - 'this URI.'), 536 536 + 'A read/write copy of the repository will be served from this URI.'), 539 537 'short' => pht('Serve repository in read/write mode.'), 540 538 ), 541 539 );

+1 -1

src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php

reviewed

··· 129 129 $protocol_table = id(new AphrontTableView($protocol_rows)) 130 130 ->setNoDataString( 131 131 pht( 132 132 - 'Phabricator is not configured to allow any editor protocols.')) 132 132 + 'No allowed editor protocols are configured.')) 133 133 ->setHeaders( 134 134 array( 135 135 pht('Protocol'),

+1 -1

src/applications/settings/setting/PhabricatorEmailStampsSetting.php

reviewed

··· 22 22 23 23 protected function getControlInstructions() { 24 24 return pht(<<<EOREMARKUP 25 25 - Phabricator stamps mail with labels like `actor(alice)` which can be used to 25 25 + Outgoing mail is stamped with labels like `actor(alice)` which can be used to 26 26 write client mail rules to organize mail. By default, these stamps are sent 27 27 in an `X-Phabricator-Stamps` header. 28 28

+1 -1

src/applications/settings/setting/PhabricatorTranslationSetting.php

reviewed

··· 23 23 24 24 protected function getControlInstructions() { 25 25 return pht( 26 26 - 'Choose which language you would like the Phabricator UI to use.'); 26 26 + 'Choose which language you would like the UI to use.'); 27 27 } 28 28 29 29 public function assertValidValue($value) {

+11 -10

src/applications/system/controller/PhabricatorSystemReadOnlyController.php

reviewed

··· 16 16 case PhabricatorEnv::READONLY_CONFIG: 17 17 $title = pht('Administrative Read-Only Mode'); 18 18 $body[] = pht( 19 19 - 'An administrator has placed Phabricator into read-only mode.'); 19 19 + 'An administrator has placed this server into read-only mode.'); 20 20 $body[] = pht( 21 21 'This mode may be used to perform temporary maintenance, test '. 22 22 'configuration, or archive an installation permanently.'); ··· 24 24 'Read-only mode was enabled by the explicit action of a human '. 25 25 'administrator, so you can get more information about why it '. 26 26 'has been turned on by rolling your chair away from your desk and '. 27 27 - 'yelling "Hey! Why is Phabricator in read-only mode??!" using '. 28 28 - 'your very loudest outside voice.'); 27 27 + 'yelling "Hey! Why is %s in read-only mode??!" using '. 28 28 + 'your very loudest outside voice.', 29 29 + PlatformSymbols::getPlatformServerSymbol()); 29 30 $body[] = pht( 30 31 'This mode is active because it is enabled in the configuration '. 31 32 'option "%s".', ··· 35 36 case PhabricatorEnv::READONLY_MASTERLESS: 36 37 $title = pht('No Writable Database'); 37 38 $body[] = pht( 38 38 - 'Phabricator is currently configured with no writable ("master") '. 39 39 + 'This server is currently configured with no writable ("master") '. 39 40 'database, so it can not write new information anywhere. '. 40 40 - 'Phabricator will run in read-only mode until an administrator '. 41 41 + 'This server will run in read-only mode until an administrator '. 41 42 'reconfigures it with a writable database.'); 42 43 $body[] = pht( 43 44 'This usually occurs when an administrator is actively working on '. ··· 52 53 case PhabricatorEnv::READONLY_UNREACHABLE: 53 54 $title = pht('Unable to Reach Master'); 54 55 $body[] = pht( 55 55 - 'Phabricator was unable to connect to the writable ("master") '. 56 56 + 'This server was unable to connect to the writable ("master") '. 56 57 'database while handling this request, and automatically degraded '. 57 58 'into read-only mode.'); 58 59 $body[] = pht( 59 60 'This may happen if there is a temporary network anomaly on the '. 60 61 'server side, like cosmic radiation or spooky ghosts. If this '. 61 62 'failure was caused by a transient service interruption, '. 62 62 - 'Phabricator will recover momentarily.'); 63 63 + 'this server will recover momentarily.'); 63 64 $body[] = pht( 64 65 'This may also indicate that a more serious failure has occurred. '. 65 65 - 'If this interruption does not resolve on its own, Phabricator '. 66 66 + 'If this interruption does not resolve on its own, this server '. 66 67 'will soon detect the persistent disruption and degrade into '. 67 68 'read-only mode until the issue is resolved.'); 68 69 $button = pht('Quite Unsettling'); ··· 70 71 case PhabricatorEnv::READONLY_SEVERED: 71 72 $title = pht('Severed From Master'); 72 73 $body[] = pht( 73 73 - 'Phabricator has consistently been unable to reach the writable '. 74 74 + 'This server has consistently been unable to reach the writable '. 74 75 '("master") database while processing recent requests.'); 75 76 $body[] = pht( 76 77 'This likely indicates a severe misconfiguration or major service '. 77 78 'interruption.'); 78 79 $body[] = pht( 79 79 - 'Phabricator will periodically retry the connection and recover '. 80 80 + 'This server will periodically retry the connection and recover '. 80 81 'once service is restored. Most causes of persistent service '. 81 82 'interruption will require administrative intervention in order '. 82 83 'to restore service.');

+3 -3

src/applications/transactions/conduit/TransactionSearchConduitAPIMethod.php

reviewed

··· 15 15 16 16 protected function newDocumentationPages(PhabricatorUser $viewer) { 17 17 $markup = pht(<<<EOREMARKUP 18 18 - When an object (like a task) is edited, Phabricator creates a "transaction" 19 19 - and applies it. This list of transactions on each object is the basis for 20 20 - essentially all edits and comments in Phabricator. Reviewing the transaction 18 18 + When an object (like a task) is edited, the relevant application creates a 19 19 + "transaction" and applies it. This list of transactions on each object is the 20 20 + basis for essentially all edits and comments. Reviewing the transaction 21 21 record allows you to see who edited an object, when, and how their edit changed 22 22 things. 23 23