@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Put Drydock build steps into their own group in Harbormaster

Summary: Ref T9252. Move these into a new "Drydock" group.

Test Plan: Clicked "Add Build Step", saw Drydock steps in a Drydock group.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9252

Differential Revision: https://secure.phabricator.com/D14237

+30 -3
+2
src/__phutil_library_map__.php
··· 1011 1011 'HarbormasterController' => 'applications/harbormaster/controller/HarbormasterController.php', 1012 1012 'HarbormasterCreateArtifactConduitAPIMethod' => 'applications/harbormaster/conduit/HarbormasterCreateArtifactConduitAPIMethod.php', 1013 1013 'HarbormasterDAO' => 'applications/harbormaster/storage/HarbormasterDAO.php', 1014 + 'HarbormasterDrydockBuildStepGroup' => 'applications/harbormaster/stepgroup/HarbormasterDrydockBuildStepGroup.php', 1014 1015 'HarbormasterDrydockCommandBuildStepImplementation' => 'applications/harbormaster/step/HarbormasterDrydockCommandBuildStepImplementation.php', 1015 1016 'HarbormasterDrydockLeaseArtifact' => 'applications/harbormaster/artifact/HarbormasterDrydockLeaseArtifact.php', 1016 1017 'HarbormasterExecFuture' => 'applications/harbormaster/future/HarbormasterExecFuture.php', ··· 4813 4814 'HarbormasterController' => 'PhabricatorController', 4814 4815 'HarbormasterCreateArtifactConduitAPIMethod' => 'HarbormasterConduitAPIMethod', 4815 4816 'HarbormasterDAO' => 'PhabricatorLiskDAO', 4817 + 'HarbormasterDrydockBuildStepGroup' => 'HarbormasterBuildStepGroup', 4816 4818 'HarbormasterDrydockCommandBuildStepImplementation' => 'HarbormasterBuildStepImplementation', 4817 4819 'HarbormasterDrydockLeaseArtifact' => 'HarbormasterArtifact', 4818 4820 'HarbormasterExecFuture' => 'Future',
+1 -1
src/applications/harbormaster/controller/HarbormasterPlanEditController.php
··· 61 61 $is_new = (!$plan->getID()); 62 62 if ($is_new) { 63 63 $title = pht('New Build Plan'); 64 - $cancel_uri = $this->getApplicationURI(); 64 + $cancel_uri = $this->getApplicationURI('plan/'); 65 65 $save_button = pht('Create Build Plan'); 66 66 } else { 67 67 $id = $plan->getID();
+1 -1
src/applications/harbormaster/step/HarbormasterDrydockCommandBuildStepImplementation.php
··· 12 12 } 13 13 14 14 public function getBuildStepGroupKey() { 15 - return HarbormasterPrototypeBuildStepGroup::GROUPKEY; 15 + return HarbormasterDrydockBuildStepGroup::GROUPKEY; 16 16 } 17 17 18 18 public function getDescription() {
+1 -1
src/applications/harbormaster/step/HarbormasterLeaseWorkingCopyBuildStepImplementation.php
··· 12 12 } 13 13 14 14 public function getBuildStepGroupKey() { 15 - return HarbormasterPrototypeBuildStepGroup::GROUPKEY; 15 + return HarbormasterDrydockBuildStepGroup::GROUPKEY; 16 16 } 17 17 18 18 public function execute(
+25
src/applications/harbormaster/stepgroup/HarbormasterDrydockBuildStepGroup.php
··· 1 + <?php 2 + 3 + final class HarbormasterDrydockBuildStepGroup 4 + extends HarbormasterBuildStepGroup { 5 + 6 + const GROUPKEY = 'harbormaster.drydock'; 7 + 8 + public function getGroupName() { 9 + return pht('Drydock'); 10 + } 11 + 12 + public function getGroupOrder() { 13 + return 3000; 14 + } 15 + 16 + public function isEnabled() { 17 + $drydock_class = 'PhabricatorDrydockApplication'; 18 + return PhabricatorApplication::isClassInstalled($drydock_class); 19 + } 20 + 21 + public function shouldShowIfEmpty() { 22 + return false; 23 + } 24 + 25 + }