@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
make is to when a user resigns from an audit they are no longer cc'd
Summary: do this by making sure to filter out those who've "resigned" from the email CC list
Test Plan: resigned from an audit and no longer got emails on updates
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Maniphest Tasks: T2033
Differential Revision: https://secure.phabricator.com/D3890
+6
-3
+6
-3
src/applications/audit/editor/PhabricatorAuditCommentEditor.php
+6
-3
src/applications/audit/editor/PhabricatorAuditCommentEditor.php
···
395
395
$email_to[] = $author_phid;
396
396
}
397
397
398
-
$email_cc = array();
399
398
foreach ($other_comments as $other_comment) {
400
-
$email_cc[] = $other_comment->getActorPHID();
399
+
$email_cc[$other_comment->getActorPHID()] = true;
401
400
}
402
401
403
402
foreach ($requests as $request) {
404
403
if ($request->getAuditStatus() == PhabricatorAuditStatusConstants::CC) {
405
-
$email_cc[] = $request->getAuditorPHID();
404
+
$email_cc[$request->getAuditorPHID()] = true;
405
+
} else if ($request->getAuditStatus() ==
406
+
PhabricatorAuditStatusConstants::RESIGNED) {
407
+
unset($email_cc[$request->getAuditorPHID()]);
406
408
}
407
409
}
410
+
$email_cc = array_keys($email_cc);
408
411
409
412
$phids = array_merge($email_to, $email_cc);
410
413
$handles = id(new PhabricatorObjectHandleData($phids))->loadHandles();