@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Remove "DifferentialEditPolicyField" custom field
Summary: Ref T11114. This is now entirely handled by EditEngine and standard policy code.
Test Plan: Edited the edit policy of a revision.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T11114
Differential Revision: https://secure.phabricator.com/D17074
-53
-2
src/__phutil_library_map__.php
-2
src/__phutil_library_map__.php
···
431
431
'DifferentialDiffViewController' => 'applications/differential/controller/DifferentialDiffViewController.php',
432
432
'DifferentialDoorkeeperRevisionFeedStoryPublisher' => 'applications/differential/doorkeeper/DifferentialDoorkeeperRevisionFeedStoryPublisher.php',
433
433
'DifferentialDraft' => 'applications/differential/storage/DifferentialDraft.php',
434
-
'DifferentialEditPolicyField' => 'applications/differential/customfield/DifferentialEditPolicyField.php',
435
434
'DifferentialExactUserFunctionDatasource' => 'applications/differential/typeahead/DifferentialExactUserFunctionDatasource.php',
436
435
'DifferentialFieldParseException' => 'applications/differential/exception/DifferentialFieldParseException.php',
437
436
'DifferentialFieldValidationException' => 'applications/differential/exception/DifferentialFieldValidationException.php',
···
5082
5081
'DifferentialDiffViewController' => 'DifferentialController',
5083
5082
'DifferentialDoorkeeperRevisionFeedStoryPublisher' => 'DoorkeeperFeedStoryPublisher',
5084
5083
'DifferentialDraft' => 'DifferentialDAO',
5085
-
'DifferentialEditPolicyField' => 'DifferentialCoreCustomField',
5086
5084
'DifferentialExactUserFunctionDatasource' => 'PhabricatorTypeaheadCompositeDatasource',
5087
5085
'DifferentialFieldParseException' => 'Exception',
5088
5086
'DifferentialFieldValidationException' => 'Exception',
-1
src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
-1
src/applications/differential/config/PhabricatorDifferentialConfigOptions.php
-50
src/applications/differential/customfield/DifferentialEditPolicyField.php
-50
src/applications/differential/customfield/DifferentialEditPolicyField.php
···
1
-
<?php
2
-
3
-
final class DifferentialEditPolicyField
4
-
extends DifferentialCoreCustomField {
5
-
6
-
public function getFieldKey() {
7
-
return 'differential:edit-policy';
8
-
}
9
-
10
-
public function getFieldName() {
11
-
return pht('Edit Policy');
12
-
}
13
-
14
-
public function getFieldDescription() {
15
-
return pht('Controls who can edit a revision.');
16
-
}
17
-
18
-
protected function readValueFromRevision(
19
-
DifferentialRevision $revision) {
20
-
return $revision->getEditPolicy();
21
-
}
22
-
23
-
public function readValueFromRequest(AphrontRequest $request) {
24
-
$this->setValue($request->getStr($this->getFieldKey()));
25
-
}
26
-
27
-
public function renderEditControl(array $handles) {
28
-
$viewer = $this->getViewer();
29
-
$revision = $this->getObject();
30
-
31
-
$policies = id(new PhabricatorPolicyQuery())
32
-
->setViewer($viewer)
33
-
->setObject($revision)
34
-
->execute();
35
-
36
-
return id(new AphrontFormPolicyControl())
37
-
->setUser($viewer)
38
-
->setCapability(PhabricatorPolicyCapability::CAN_EDIT)
39
-
->setPolicyObject($revision)
40
-
->setPolicies($policies)
41
-
->setName($this->getFieldKey())
42
-
->setValue($this->getValue())
43
-
->setError($this->getFieldError());
44
-
}
45
-
46
-
public function getApplicationTransactionType() {
47
-
return PhabricatorTransactions::TYPE_EDIT_POLICY;
48
-
}
49
-
50
-
}