@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Show a snippet when hovering inlines in the objective list
Summary: Ref T12733. Shows a comment snippet when hovering inlines in the objective list.
Test Plan: {F4968490}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T12733
Differential Revision: https://secure.phabricator.com/D17980
+14
-11
+6
-6
resources/celerity/map.php
+6
-6
resources/celerity/map.php
···
13
13
'core.pkg.js' => '599698a7',
14
14
'darkconsole.pkg.js' => '1f9a31bc',
15
15
'differential.pkg.css' => '7d4cfa59',
16
-
'differential.pkg.js' => 'd7e3edd5',
16
+
'differential.pkg.js' => '06cddcc0',
17
17
'diffusion.pkg.css' => 'b93d9b8c',
18
18
'diffusion.pkg.js' => '84c8f8fd',
19
19
'favicon.ico' => '30672e08',
···
392
392
'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63',
393
393
'rsrc/js/application/diff/DiffChangeset.js' => 'cf4e2140',
394
394
'rsrc/js/application/diff/DiffChangesetList.js' => 'a716ca27',
395
-
'rsrc/js/application/diff/DiffInline.js' => 'ca0fafde',
395
+
'rsrc/js/application/diff/DiffInline.js' => '4478f8ac',
396
396
'rsrc/js/application/diff/ScrollObjective.js' => '9df4e4e2',
397
397
'rsrc/js/application/diff/ScrollObjectiveList.js' => '085dd101',
398
398
'rsrc/js/application/diff/behavior-preview-link.js' => '051c7832',
···
779
779
'phabricator-dashboard-css' => 'fe5b1869',
780
780
'phabricator-diff-changeset' => 'cf4e2140',
781
781
'phabricator-diff-changeset-list' => 'a716ca27',
782
-
'phabricator-diff-inline' => 'ca0fafde',
782
+
'phabricator-diff-inline' => '4478f8ac',
783
783
'phabricator-drag-and-drop-file-upload' => '58dea2fa',
784
784
'phabricator-draggable-list' => 'bea6e7f4',
785
785
'phabricator-fatal-config-template-css' => '8f18fa41',
···
1203
1203
'javelin-workflow',
1204
1204
'javelin-workboard-controller',
1205
1205
),
1206
+
'4478f8ac' => array(
1207
+
'javelin-dom',
1208
+
),
1206
1209
'44959b73' => array(
1207
1210
'javelin-util',
1208
1211
'javelin-uri',
···
1975
1978
'phabricator-title',
1976
1979
'phabricator-shaped-request',
1977
1980
'conpherence-thread-manager',
1978
-
),
1979
-
'ca0fafde' => array(
1980
-
'javelin-dom',
1981
1981
),
1982
1982
'caade6f2' => array(
1983
1983
'javelin-behavior',
+5
-4
src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
+5
-4
src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
···
421
421
$actions,
422
422
));
423
423
424
+
$snippet = id(new PhutilUTF8StringTruncator())
425
+
->setMaximumGlyphs(96)
426
+
->truncateString($inline->getContent());
427
+
$metadata['snippet'] = pht('%s: %s', $author, $snippet);
428
+
424
429
$markup = javelin_tag(
425
430
'div',
426
431
array(
···
443
448
'differential-inline-comment-content',
444
449
phutil_tag_div('phabricator-remarkup', $content)),
445
450
));
446
-
447
-
$snippet = id(new PhutilUTF8StringTruncator())
448
-
->setMaximumGlyphs(96)
449
-
->truncateString($inline->getContent());
450
451
451
452
$summary = phutil_tag(
452
453
'div',
+3
-1
webroot/rsrc/js/application/diff/DiffInline.js
+3
-1
webroot/rsrc/js/application/diff/DiffInline.js
···
22
22
_undoRow: null,
23
23
_replyToCommentPHID: null,
24
24
_originalText: null,
25
+
_snippet: null,
25
26
26
27
_isDeleted: false,
27
28
_isInvisible: false,
···
75
76
76
77
this._changesetID = data.changesetID;
77
78
this._isNew = false;
79
+
this._snippet = data.snippet;
78
80
79
81
this.setInvisible(false);
80
82
···
219
221
220
222
var icon = 'fa-comment';
221
223
var color = 'bluegrey';
222
-
var tooltip = null;
224
+
var tooltip = this._snippet;
223
225
var anchor = this._row;
224
226
225
227
if (this._isEditing) {