recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Transactions - fix edit submit URI

Summary:
tracing this a bit, in core/behavior-form.js we end up doing form.submit() on this form. Before this patch, the form had no submitURI set so it ended up doing a page load. Now, we set the submitURI and (at least) the form is actually submitted and data is saved. Ref T4669.

Not sure how come the syntheticSubmit even isn't getting picked up though?

Test Plan: hit apple + enter to submit comment edit. page reloaded and my edit persisted!

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T4669

Differential Revision: https://secure.phabricator.com/D8952

Bob Trahan 4e4a520b 97f88f46

+2
+2
src/applications/transactions/controller/PhabricatorApplicationTransactionCommentEditController.php
··· 60 60 61 61 $dialog = id(new AphrontDialogView()) 62 62 ->setUser($user) 63 + ->setSubmitURI( 64 + $this->getApplicationURI('/transactions/edit/'.$xaction->getPHID().'/')) 63 65 ->setTitle(pht('Edit Comment')); 64 66 65 67 $dialog