@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Adjust the shade of green in blame
Summary:
We are loading blame on background which confuses me a bit - I'm not sure if it's still loading or it's already loaded and the commit changed lots of lines (so I don't see the author) and it was a long time ago (so I don't see green).
Provide a visual feedback even for very old commits.
I want to point out that I really enjoy this kind of work.
Also, this diff is my masterpiece at least for today.
Test Plan: ?view=blame - verified that the gray changed to a decent shade of green even for very old commits.
Reviewers: epriestley, chad
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D5292
+1
-1
+1
-1
src/applications/diffusion/controller/DiffusionBrowseFileController.php
+1
-1
src/applications/diffusion/controller/DiffusionBrowseFileController.php
···
485
485
$color = '#ffd'; // Render as warning.
486
486
} else {
487
487
$color_ratio = ($blame['epoch'] - $epoch_min) / $epoch_range;
488
-
$color_value = 0xF6 * (1.0 - $color_ratio);
488
+
$color_value = 0xE6 * (1.0 - $color_ratio);
489
489
$color = sprintf(
490
490
'#%02x%02x%02x',
491
491
$color_value,