@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix Maniphest fatal when editing a task without changing anything
Summary:
Transaction editor attempted to do things with an empty transaction array, just
skip editing ops if nothing changed.
Test Plan:
Edited a Maniphest task without changing anything.
Reviewed By: tuomaspelkonen
Reviewers: tuomaspelkonen, jungejason, aran
CC: sandra, anjali, aran, tuomaspelkonen
Differential Revision: 248
+4
-2
+4
-2
src/applications/maniphest/controller/taskedit/ManiphestTaskEditController.php
+4
-2
src/applications/maniphest/controller/taskedit/ManiphestTaskEditController.php
···
136
136
$transactions[] = $transaction;
137
137
}
138
138
139
-
$editor = new ManiphestTransactionEditor();
140
-
$editor->applyTransactions($task, $transactions);
139
+
if ($transactions) {
140
+
$editor = new ManiphestTransactionEditor();
141
+
$editor->applyTransactions($task, $transactions);
142
+
}
141
143
142
144
return id(new AphrontRedirectResponse())
143
145
->setURI('/T'.$task->getID());