recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Portals: Rename unused newNoMenuItemsView() to newNoContentView()

Summary:
Followup to rPf8b8d88

Rename uncalled `newNoMenuItemsView()` to `newNoContentView()` overwriting this method in the parent class, to fix showing more specific UI messages for empty portals.

Test Plan:
Code:
* Grep the code for non-existing `newNoMenuItemsView`
* Check code of parent class `PhabricatorProfileMenuEngine`
Workflows:
* Create an empty portal via http://phorge.localhost/portal/edit/form/default/, see correct (more specific) string "Use "Edit Menu" to add menu items to this portal." displayed
* Click "Edit Menu" to go to http://phorge.localhost/portal/view/1/configure/global/ of that Portal just created, on the right in "Add New Menu Item..." select "Divider" and click "Create Menu Item" button, go back to portal, see correct (more specific) string "None of the visible menu items in this portal can render any content." displayed

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Tags: #dashboards

Differential Revision: https://we.phorge.it/D25776

Andre Klapper 4f3aad4f 883ec909

+2 -2
+2 -2
src/applications/dashboard/engine/PhabricatorDashboardPortalProfileMenuEngine.php
··· 32 32 return $items; 33 33 } 34 34 35 - protected function newNoMenuItemsView(array $items) { 35 + protected function newNoContentView(array $items) { 36 36 $object = $this->getProfileObject(); 37 37 $builtins = $this->getBuiltinProfileItems($object); 38 38 ··· 41 41 pht('New Portal'), 42 42 pht('Use "Edit Menu" to add menu items to this portal.')); 43 43 } else { 44 - return $this->newNoContentView( 44 + return $this->newEmptyView( 45 45 pht('No Portal Content'), 46 46 pht( 47 47 'None of the visible menu items in this portal can render any '.