@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
When using "bin/bulk export --overwrite", actually overwrite the file
Summary: Depends on D19738. Ref T13210. Currently, when you use "--overwrite", we just //append// the new content. Instead, actually overwrite the file.
Test Plan: Used `--overwrite`, saw an actual clean overwrite instead of an append.
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T13210
Differential Revision: https://secure.phabricator.com/D19739
+4
+4
src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php
+4
src/applications/transactions/bulk/management/PhabricatorBulkManagementExportWorkflow.php
···
114
114
$iterator = $file->getFileDataIterator();
115
115
116
116
if (strlen($output_path)) {
117
+
// Empty the file before we start writing to it. Otherwise, "--overwrite"
118
+
// will really mean "--append".
119
+
Filesystem::writeFile($output_path, '');
120
+
117
121
foreach ($iterator as $chunk) {
118
122
Filesystem::appendFile($output_path, $chunk);
119
123
}