@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add some descriptive properties when viewing a Calendar import
Summary: Ref T10747. When viewing an import detail page, show a little more information about what you're looking at.
Test Plan: {F1876957}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10747
Differential Revision: https://secure.phabricator.com/D16726
+37
+11
src/applications/calendar/controller/PhabricatorCalendarImportViewController.php
+11
src/applications/calendar/controller/PhabricatorCalendarImportViewController.php
···
151
151
$properties = id(new PHUIPropertyListView())
152
152
->setViewer($viewer);
153
153
154
+
$engine = $import->getEngine();
155
+
156
+
$properties->addProperty(
157
+
pht('Source Type'),
158
+
$engine->getImportEngineTypeName());
159
+
160
+
$engine->appendImportProperties(
161
+
$viewer,
162
+
$import,
163
+
$properties);
164
+
154
165
return $properties;
155
166
}
156
167
+18
src/applications/calendar/import/PhabricatorCalendarICSImportEngine.php
+18
src/applications/calendar/import/PhabricatorCalendarICSImportEngine.php
···
9
9
return pht('Import .ics File');
10
10
}
11
11
12
+
public function getImportEngineTypeName() {
13
+
return pht('.ics File');
14
+
}
15
+
12
16
public function getImportEngineHint() {
13
17
return pht('Import an event in ".ics" (iCalendar) format.');
18
+
}
19
+
20
+
21
+
public function appendImportProperties(
22
+
PhabricatorUser $viewer,
23
+
PhabricatorCalendarImport $import,
24
+
PHUIPropertyListView $properties) {
25
+
26
+
$phid_key = PhabricatorCalendarImportICSFileTransaction::PARAMKEY_FILE;
27
+
$file_phid = $import->getParameter($phid_key);
28
+
29
+
$properties->addProperty(
30
+
pht('Source File'),
31
+
$viewer->renderHandle($file_phid));
14
32
}
15
33
16
34
public function newEditEngineFields(
+8
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
+8
src/applications/calendar/import/PhabricatorCalendarImportEngine.php
···
9
9
10
10
11
11
abstract public function getImportEngineName();
12
+
abstract public function getImportEngineTypeName();
12
13
abstract public function getImportEngineHint();
14
+
15
+
public function appendImportProperties(
16
+
PhabricatorUser $viewer,
17
+
PhabricatorCalendarImport $import,
18
+
PHUIPropertyListView $properties) {
19
+
return;
20
+
}
13
21
14
22
abstract public function newEditEngineFields(
15
23
PhabricatorEditEngine $engine,