recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exception rendering files/documents

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php:211]
```

Closes T15826

Test Plan: Surf a Diffusion repository and play with {nav View Options}.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15826

Differential Revision: https://we.phorge.it/D25638

Andre Klapper 50d0bbe8 464a0aed

+2 -2
+2 -2
src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php
··· 208 208 $this->activeEngine = $engine; 209 209 210 210 $encode_setting = $request->getStr('encode'); 211 - if (strlen($encode_setting)) { 211 + if (phutil_nonempty_string($encode_setting)) { 212 212 $engine->setEncodingConfiguration($encode_setting); 213 213 } 214 214 215 215 $highlight_setting = $request->getStr('highlight'); 216 - if (strlen($highlight_setting)) { 216 + if (phutil_nonempty_string($highlight_setting)) { 217 217 $engine->setHighlightingConfiguration($highlight_setting); 218 218 } 219 219