@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix Versions page
Summary:
- ipull there is wrong
- The `+` wasn't doing what I thought it was doing.
- I already forgot what that detour was doing, so I wrote it down.
Test Plan: Load Versions page, see no error log.
Reviewers: #blessed_reviewers, epriestley
Reviewed By: #blessed_reviewers, epriestley
Subscribers: epriestley
Differential Revision: https://secure.phabricator.com/D14686
+3
-3
+3
-3
src/applications/config/module/PhabricatorConfigVersionsModule.php
+3
-3
src/applications/config/module/PhabricatorConfigVersionsModule.php
···
45
45
);
46
46
47
47
$all_libraries = PhutilBootloader::getInstance()->getAllLibraries();
48
-
$other_libraries = array_diff($all_libraries, ipull($specs, 'lib'));
49
-
$specs = $specs + $other_libraries;
50
-
48
+
// This puts the core libraries at the top:
49
+
$other_libraries = array_diff($all_libraries, $specs);
50
+
$specs = array_merge($specs, $other_libraries);
51
51
52
52
$futures = array();
53
53
foreach ($specs as $lib) {