recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix unmigrated load() call in Audit inlines

Summary: Fixes T5711. I missed this somehow in grepping. :/

Test Plan: Edited and deleted an inline draft.

Reviewers: chad, btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T5711

Differential Revision: https://secure.phabricator.com/D10051

epriestley 51b5bf1e 1450c0e8

+12 -1
+11
src/applications/audit/storage/PhabricatorAuditInlineComment.php
··· 28 28 return $this->proxy; 29 29 } 30 30 31 + public static function loadID($id) { 32 + $inlines = id(new PhabricatorAuditTransactionComment())->loadAllWhere( 33 + 'id = %d', 34 + $id); 35 + if (!$inlines) { 36 + return null; 37 + } 38 + 39 + return head(self::buildProxies($inlines)); 40 + } 41 + 31 42 public static function loadDraftComments( 32 43 PhabricatorUser $viewer, 33 44 $commit_phid) {
+1 -1
src/applications/diffusion/controller/DiffusionInlineCommentController.php
··· 40 40 } 41 41 42 42 protected function loadComment($id) { 43 - return id(new PhabricatorAuditInlineComment())->load($id); 43 + return PhabricatorAuditInlineComment::loadID($id); 44 44 } 45 45 46 46 protected function loadCommentForEdit($id) {