recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

PHPDoc: Replace non-existing return type const with string(|int)

Summary: `const` is not a valid type. See https://docs.phpdoc.org/guide/references/phpdoc/types.html and https://docs.phpdoc.org/guide/references/phpdoc/tags/return.html.

Test Plan: Read docs; run static code analysis.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26068

Andre Klapper 520db4e1 83494d84

+4 -3
+1 -1
src/applications/transactions/storage/PhabricatorModularTransactionType.php
··· 431 431 * @param object $object Object being edited. 432 432 * @param PhabricatorApplicationTransaction $xaction Transaction being 433 433 * applied. 434 - * @return null|const|list<const> A capability constant (or list of 434 + * @return null|string|list<string> A capability constant (or list of 435 435 * capability constants) which the actor must have on the object. You can 436 436 * return `null` as a shorthand for "no capabilities are required". 437 437 */
+1 -1
src/infrastructure/customfield/field/PhabricatorCustomField.php
··· 1554 1554 /** 1555 1555 * Get the available conditions for this field in Herald. 1556 1556 * 1557 - * @return list<const> List of Herald condition constants. 1557 + * @return list<string> List of Herald condition constants. 1558 1558 * @task herald 1559 1559 */ 1560 1560 public function getHeraldFieldConditions() {
+2 -1
src/infrastructure/edges/editor/PhabricatorEdgeEditor.php
··· 354 354 * Get a list of all edge types which are being added, and which we should 355 355 * prevent cycles on. 356 356 * 357 - * @return list<const> List of edge types which should have cycles prevented. 357 + * @return list<int|string> List of edge type constants which should have 358 + * cycles prevented. 358 359 * @task cycle 359 360 */ 360 361 private function getPreventCyclesEdgeTypes() {