@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix bug with macros search being global.
Summary: This fixed a bug with macros search finding macros flagged by any user. We should only look at flags by the current user.
Test Plan: Verify that no macros flagged by another user show up in macros search.
Reviewers: epriestley
Reviewed By: epriestley
CC: Korvin, aran
Differential Revision: https://secure.phabricator.com/D6717
authored by
Tarmo Lehtpuu
and committed by
epriestley
52225f7e
4657158e
+1
+1
src/applications/macro/query/PhabricatorMacroQuery.php
+1
src/applications/macro/query/PhabricatorMacroQuery.php
···
170
170
171
171
if ($this->flagColor != '-1' && $this->flagColor !== null) {
172
172
$flags = id(new PhabricatorFlagQuery())
173
+
->withOwnerPHIDs(array($this->getViewer()->getPHID()))
173
174
->withTypes(array(PhabricatorMacroPHIDTypeMacro::TYPECONST))
174
175
->withColor($this->flagColor)
175
176
->setViewer($this->getViewer())