@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Restore the "Download from Git LFS" UI button to Diffusion
Summary: Depends on D18827. Ref T7789. See PHI204. See PHI131. This button got accidentally removed in Diffusion refactoring (`$data` is no longer used).
Test Plan: {F5321459}
Reviewers: amckinley
Reviewed By: amckinley
Maniphest Tasks: T7789
Differential Revision: https://secure.phabricator.com/D18828
+3
-2
+3
-2
src/applications/diffusion/controller/DiffusionBrowseController.php
+3
-2
src/applications/diffusion/controller/DiffusionBrowseController.php
···
916
916
->setTag('a')
917
917
->setText($text)
918
918
->setHref($href)
919
-
->setIcon($icon);
919
+
->setIcon($icon)
920
+
->setColor(PHUIButtonView::GREY);
920
921
}
921
922
922
923
private function buildDisplayRows(
···
1924
1925
1925
1926
try {
1926
1927
$file = $this->loadGitLFSFile($ref);
1927
-
$data = $this->renderGitLFSButton();
1928
+
$this->corpusButtons[] = $this->renderGitLFSButton();
1928
1929
} catch (Exception $ex) {
1929
1930
$severity = PHUIInfoView::SEVERITY_ERROR;
1930
1931
$messages[] = pht('The data for this file could not be loaded.');