recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix broken unset() array access in DivinerAtomQuery

Summary:
Per static code analysis, `Cannot unset offset (int|string) on DivinerLiveSymbol.`
See also the similar code above which is correct.

Test Plan: Read the code; run static code analysis.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D26311

Andre Klapper 529c7042 ee038474

+1 -1
+1 -1
src/applications/diviner/query/DivinerAtomQuery.php
··· 291 291 292 292 if (!$repository) { 293 293 $this->didRejectResult($atom); 294 - unset($atom[$key]); 294 + unset($atoms[$key]); 295 295 continue; 296 296 } 297 297