@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix using result of method (void)
Summary:
`PhabricatorAuthSessionEngine::signLegalpadDocuments()` and `PhutilTestCase::tryTestCaseMap()` return void.
Thus do not assign this result to a variable as that variable is not used in the further code anyway.
Just call the method on its own line.
Test Plan: Run static code analysis (PHPStan).
Reviewers: O1 Blessed Committers, mainframe98
Reviewed By: O1 Blessed Committers, mainframe98
Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno
Differential Revision: https://we.phorge.it/D26309
+4
-4
+3
-3
src/aphront/sink/__tests__/AphrontHTTPSinkTestCase.php
+3
-3
src/aphront/sink/__tests__/AphrontHTTPSinkTestCase.php
···
16
16
}
17
17
18
18
public function testHTTPSinkStatusCode() {
19
-
$input = $this->tryTestCaseMap(
19
+
$this->tryTestCaseMap(
20
20
array(
21
21
200 => true,
22
22
'201' => true,
···
34
34
}
35
35
36
36
public function testHTTPSinkResponseSplitting() {
37
-
$input = $this->tryTestCaseMap(
37
+
$this->tryTestCaseMap(
38
38
array(
39
39
'test' => true,
40
40
"test\nx" => false,
···
50
50
}
51
51
52
52
public function testHTTPHeaderNames() {
53
-
$input = $this->tryTestCaseMap(
53
+
$this->tryTestCaseMap(
54
54
array(
55
55
'test' => true,
56
56
'test:' => false,
+1
-1
src/applications/base/controller/PhabricatorController.php
+1
-1
src/applications/base/controller/PhabricatorController.php
···
613
613
// If nothing needs to be signed (either because there are no documents
614
614
// which require a signature, or because the user has already signed
615
615
// all of them) mark the session as good and continue.
616
-
$engine = id(new PhabricatorAuthSessionEngine())
616
+
id(new PhabricatorAuthSessionEngine())
617
617
->signLegalpadDocuments($viewer, $sign_docs);
618
618
619
619
return null;