recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Correct an issue where the commit list could group commits by server time

Summary:
Commits in the list are grouped by the date they occurred in server time. This may not be the date they occurred in client time.

Use client time, not server time, to group commits.

Test Plan:
- Set server timezone to "Asia/Famagusta".
- Set client timezone to "America/Los_Angeles".
- Viewed Phabricator repository history.

Here's what it looks like before the change:

{F4987094}

Note that the headers of the first two groups both say "Yesterday".

This is because the first commits in each group occurred on June 1 and June 2, respectively, in Famagusta, but both occurred on June 1 in Los Angeles.

Here's what it looks like after the change:

{F4987095}

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D18067

epriestley 5335f29f 335c3a7d

+3 -6
+3 -6
src/applications/diffusion/view/DiffusionHistoryListView.php
··· 23 23 'PhabricatorHarbormasterApplication', 24 24 $this->getUser()); 25 25 26 - $rows = array(); 27 - $ii = 0; 28 - $cur_date = 0; 29 - $header = null; 26 + $cur_date = null; 30 27 $view = array(); 31 28 foreach ($this->getHistory() as $history) { 32 29 $epoch = $history->getEpoch(); 33 - $new_date = date('Ymd', $history->getEpoch()); 34 - if ($cur_date != $new_date) { 30 + $new_date = phabricator_date($history->getEpoch(), $viewer); 31 + if ($cur_date !== $new_date) { 35 32 $date = ucfirst( 36 33 phabricator_relative_date($history->getEpoch(), $viewer)); 37 34 $header = id(new PHUIHeaderView())