@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Don't let Diffusion show that an importing repository is "100%" imported
Summary:
A few users have hit this and found it confusing. Currently, it means "more than 99.95%", which is very different from "100%". Instead:
- show an extra digit of precision; and
- cap the display at "99.99%", so it's more clear that work is still happening.
Test Plan: Faked it and saw it cap at 99.99%.
Reviewers: btrahan
Reviewed By: btrahan
CC: aran
Differential Revision: https://secure.phabricator.com/D8058
+7
-1
+7
-1
src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
+7
-1
src/applications/diffusion/controller/DiffusionRepositoryEditMainController.php
···
954
954
$percentage = 0;
955
955
}
956
956
957
-
$percentage = sprintf('%.1f%%', $percentage);
957
+
// Cap this at "99.99%", because it's confusing to users when the actual
958
+
// fraction is "99.996%" and it rounds up to "100.00%".
959
+
if ($percentage > 99.99) {
960
+
$percentage = 99.99;
961
+
}
962
+
963
+
$percentage = sprintf('%.2f%%', $percentage);
958
964
959
965
$view->addItem(
960
966
id(new PHUIStatusItemView())