@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Use long array syntax for compatibility instead of short array syntax
Summary: Fixes T11409. This syntax isn't compatible with older PHP.
Test Plan: Ran `arc lint` on the file.
Reviewers: yelirekim, chad
Reviewed By: chad
Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam
Maniphest Tasks: T11409
Differential Revision: https://secure.phabricator.com/D16358
+6
-3
+6
-3
src/applications/harbormaster/conduit/HarbormasterQueryBuildsConduitAPIMethod.php
+6
-3
src/applications/harbormaster/conduit/HarbormasterQueryBuildsConduitAPIMethod.php
···
56
56
$subsumption = $call->setUser($viewer)
57
57
->execute();
58
58
59
-
$data = [];
59
+
$data = array();
60
60
foreach ($subsumption['data'] as $build_data) {
61
-
$querybuilds = idxv($build_data, array('attachments', 'querybuilds'), []);
62
-
$fields = idx($build_data, 'fields', []);
61
+
$querybuilds = idxv(
62
+
$build_data,
63
+
array('attachments', 'querybuilds'),
64
+
array());
65
+
$fields = idx($build_data, 'fields', array());
63
66
unset($build_data['fields']);
64
67
unset($build_data['attachments']);
65
68
$data[] = array_mergev(array($build_data, $querybuilds, $fields));