recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix PHP 8.1 "strlen(null)" exception setting Story Points on a Task

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Here we adopt `phutil_string_cast()` to
reply to the question "is this an empty string?".

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_string_cast() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15390

Test Plan:
Enable `maniphest.points` in settings, for example with:

```
./bin/config set maniphest.points --stdin <<< '{"enabled":true}'
```

Then try to create a Task: it does not explode anymore in PHP 8.1+.

Also try to set various possible values from the Conduit API method "maniphest.edit".

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15390

Differential Revision: https://we.phorge.it/D25222

Andre Klapper 538cccc6 3999a286

+10 -1
+10 -1
src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
··· 97 97 return 'fa-calculator'; 98 98 } 99 99 100 + /** 101 + * Normalize your Story Points from generic stuff to double or null. 102 + * @param mixed $value Your raw Story Points 103 + * @return double|null 104 + */ 100 105 private function getValueForPoints($value) { 101 - if (!strlen($value)) { 106 + // The Point can be various types also thanks to Conduit API 107 + // like integers, floats, null, and strings of course. 108 + // Everything meaningful must be printable as a string. 109 + $is_empty = phutil_string_cast($value) === ''; 110 + if ($is_empty) { 102 111 $value = null; 103 112 } 104 113 if ($value !== null) {