@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Add standard spacing around viewing panels
Summary: Just wraps them in some boxes in edit and standalone mode.
Test Plan: Tested 3 panels in edit and standalone mode.
Reviewers: btrahan, epriestley
Reviewed By: epriestley
Subscribers: epriestley, Korvin
Differential Revision: https://secure.phabricator.com/D9232
+11
-2
+5
-1
src/applications/dashboard/controller/PhabricatorDashboardPanelRenderController.php
+5
-1
src/applications/dashboard/controller/PhabricatorDashboardPanelRenderController.php
···
54
54
->addTextCrumb($panel->getMonogram(), '/'.$panel->getMonogram())
55
55
->addTextCrumb(pht('Standalone View'));
56
56
57
+
$view = id(new PHUIBoxView())
58
+
->addMargin(PHUI::MARGIN_LARGE)
59
+
->appendChild($rendered_panel);
60
+
57
61
return $this->buildApplicationPage(
58
62
array(
59
63
$crumbs,
60
-
$rendered_panel,
64
+
$view,
61
65
),
62
66
array(
63
67
'title' => array(pht('Panel'), $panel->getName()),
+6
-1
src/applications/dashboard/controller/PhabricatorDashboardPanelViewController.php
+6
-1
src/applications/dashboard/controller/PhabricatorDashboardPanelViewController.php
···
44
44
->setParentPanelPHIDs(array())
45
45
->renderPanel();
46
46
47
+
$view = id(new PHUIBoxView())
48
+
->addMargin(PHUI::MARGIN_LARGE_LEFT)
49
+
->addMargin(PHUI::MARGIN_LARGE_RIGHT)
50
+
->appendChild($rendered_panel);
51
+
47
52
return $this->buildApplicationPage(
48
53
array(
49
54
$crumbs,
50
55
$box,
51
56
$timeline,
52
-
$rendered_panel,
57
+
$view,
53
58
),
54
59
array(
55
60
'title' => $title,