@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Try using a less-rich but less-risky thread title in Conpherence handles
Summary: Ref T8478. This is easier than I thought, let's see if it's conspicious?
Test Plan:
- Embedded `{Z2}` and saw "Private Correspondence".
- Still saw normal stuff with useful participant lists/titles in all main UIs.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T8478
Differential Revision: https://secure.phabricator.com/D13220
+18
-3
+1
-3
src/applications/conpherence/phid/PhabricatorConpherenceThreadPHIDType.php
+1
-3
src/applications/conpherence/phid/PhabricatorConpherenceThreadPHIDType.php
···
19
19
protected function buildQueryForObjects(
20
20
PhabricatorObjectQuery $query,
21
21
array $phids) {
22
-
23
22
return id(new ConpherenceThreadQuery())
24
-
->needParticipantCache(true)
25
23
->withPHIDs($phids);
26
24
}
27
25
···
33
31
foreach ($handles as $phid => $handle) {
34
32
$thread = $objects[$phid];
35
33
36
-
$title = $thread->getDisplayTitle($query->getViewer());
34
+
$title = $thread->getStaticTitle();
37
35
$monogram = $thread->getMonogram();
38
36
39
37
$handle->setName($title);
+17
src/applications/conpherence/storage/ConpherenceThread.php
+17
src/applications/conpherence/storage/ConpherenceThread.php
···
199
199
return PhabricatorUser::getDefaultProfileImageURI();
200
200
}
201
201
202
+
/**
203
+
* Get a thread title which doesn't require handles to be attached.
204
+
*
205
+
* This is a less rich title than @{method:getDisplayTitle}, but does not
206
+
* require handles to be attached. We use it to build thread handles without
207
+
* risking cycles or recursion while querying.
208
+
*
209
+
* @return string Lower quality human-readable title.
210
+
*/
211
+
public function getStaticTitle() {
212
+
$title = $this->getTitle();
213
+
if (strlen($title)) {
214
+
return $title;
215
+
}
216
+
217
+
return pht('Private Correspondence');
218
+
}
202
219
203
220
/**
204
221
* Get the thread's display title for a user.