@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Slightly reduce the cost of resolving refs
Summary: Ref T2683. By resolving the stable name earlier, we can save a resolve when viewing branch heads. This is ~100ms in Mercurial, and roughly 25% of page weight. It's less bad in Git.
Test Plan: Saw page cost go down in "Services" tab, particularly for Mercurial browse views.
Reviewers: btrahan
Reviewed By: btrahan
Subscribers: epriestley
Maniphest Tasks: T2683
Differential Revision: https://secure.phabricator.com/D9048
+1
-1
+1
-1
src/applications/diffusion/controller/DiffusionBrowseMainController.php
+1
-1
src/applications/diffusion/controller/DiffusionBrowseMainController.php
···
19
19
'diffusion.browsequery',
20
20
array(
21
21
'path' => $drequest->getPath(),
22
-
'commit' => $drequest->getCommit(),
22
+
'commit' => $drequest->getStableCommitName(),
23
23
)));
24
24
$reason = $results->getReasonForEmptyResultSet();
25
25
$is_file = ($reason == DiffusionBrowseResultSet::REASON_IS_FILE);