recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Herald - add support for "assignee" conditions

Summary: add support for "assignee" conditions

Test Plan: Create a Herald rule where condition is assignee, and create a task assign to someone.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7813

authored by

xiaogaozi and committed by
epriestley 54a0dd81 a70de394

+7 -1
+3
src/applications/herald/adapter/HeraldAdapter.php
··· 8 8 const FIELD_TITLE = 'title'; 9 9 const FIELD_BODY = 'body'; 10 10 const FIELD_AUTHOR = 'author'; 11 + const FIELD_ASSIGNEE = 'assignee'; 11 12 const FIELD_REVIEWER = 'reviewer'; 12 13 const FIELD_REVIEWERS = 'reviewers'; 13 14 const FIELD_COMMITTER = 'committer'; ··· 150 151 self::FIELD_TITLE => pht('Title'), 151 152 self::FIELD_BODY => pht('Body'), 152 153 self::FIELD_AUTHOR => pht('Author'), 154 + self::FIELD_ASSIGNEE => pht('Assignee'), 153 155 self::FIELD_COMMITTER => pht('Committer'), 154 156 self::FIELD_REVIEWER => pht('Reviewer'), 155 157 self::FIELD_REVIEWERS => pht('Reviewers'), ··· 230 232 self::CONDITION_IS_NOT_ANY, 231 233 ); 232 234 case self::FIELD_REPOSITORY: 235 + case self::FIELD_ASSIGNEE: 233 236 return array( 234 237 self::CONDITION_IS_ANY, 235 238 self::CONDITION_IS_NOT_ANY,
+3
src/applications/herald/adapter/HeraldManiphestTaskAdapter.php
··· 60 60 self::FIELD_TITLE, 61 61 self::FIELD_BODY, 62 62 self::FIELD_AUTHOR, 63 + self::FIELD_ASSIGNEE, 63 64 self::FIELD_CC, 64 65 self::FIELD_CONTENT_SOURCE, 65 66 self::FIELD_PROJECTS, ··· 102 103 return $this->getTask()->getDescription(); 103 104 case self::FIELD_AUTHOR: 104 105 return $this->getTask()->getAuthorPHID(); 106 + case self::FIELD_ASSIGNEE: 107 + return $this->getTask()->getOwnerPHID(); 105 108 case self::FIELD_CC: 106 109 return $this->getTask()->getCCPHIDs(); 107 110 case self::FIELD_PROJECTS:
+1 -1
src/applications/herald/storage/HeraldRule.php
··· 16 16 protected $ruleType; 17 17 protected $isDisabled = 0; 18 18 19 - protected $configVersion = 19; 19 + protected $configVersion = 20; 20 20 21 21 // phids for which this rule has been applied 22 22 private $ruleApplied = self::ATTACHABLE;