@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Adds 'setSubHead' to Objectlist
Summary: There are a few places a third text row in ObjectItemListView is needed or make things easier to read. Built and rolled out in Config.
Test Plan: Tested in Config Groups.
Reviewers: epriestley
Reviewed By: epriestley
CC: aran, Korvin
Differential Revision: https://secure.phabricator.com/D5837
+70
-39
+39
-39
src/__celerity_resource_map__.php
+39
-39
src/__celerity_resource_map__.php
···
3195
3195
),
3196
3196
'phabricator-object-item-list-view-css' =>
3197
3197
array(
3198
-
'uri' => '/res/c49799c6/rsrc/css/layout/phabricator-object-item-list-view.css',
3198
+
'uri' => '/res/439ecf73/rsrc/css/layout/phabricator-object-item-list-view.css',
3199
3199
'type' => 'css',
3200
3200
'requires' =>
3201
3201
array(
···
4002
4002
), array(
4003
4003
'packages' =>
4004
4004
array(
4005
-
55644450 =>
4005
+
'25d66007' =>
4006
4006
array(
4007
4007
'name' => 'core.pkg.css',
4008
4008
'symbols' =>
···
4044
4044
34 => 'phabricator-object-item-list-view-css',
4045
4045
35 => 'global-drag-and-drop-css',
4046
4046
),
4047
-
'uri' => '/res/pkg/55644450/core.pkg.css',
4047
+
'uri' => '/res/pkg/25d66007/core.pkg.css',
4048
4048
'type' => 'css',
4049
4049
),
4050
4050
'26980a1c' =>
···
4235
4235
'reverse' =>
4236
4236
array(
4237
4237
'aphront-attached-file-view-css' => '6b1fccc6',
4238
-
'aphront-dialog-view-css' => '55644450',
4239
-
'aphront-error-view-css' => '55644450',
4240
-
'aphront-form-view-css' => '55644450',
4241
-
'aphront-list-filter-view-css' => '55644450',
4242
-
'aphront-pager-view-css' => '55644450',
4243
-
'aphront-panel-view-css' => '55644450',
4244
-
'aphront-table-view-css' => '55644450',
4245
-
'aphront-tokenizer-control-css' => '55644450',
4246
-
'aphront-tooltip-css' => '55644450',
4247
-
'aphront-typeahead-control-css' => '55644450',
4238
+
'aphront-dialog-view-css' => '25d66007',
4239
+
'aphront-error-view-css' => '25d66007',
4240
+
'aphront-form-view-css' => '25d66007',
4241
+
'aphront-list-filter-view-css' => '25d66007',
4242
+
'aphront-pager-view-css' => '25d66007',
4243
+
'aphront-panel-view-css' => '25d66007',
4244
+
'aphront-table-view-css' => '25d66007',
4245
+
'aphront-tokenizer-control-css' => '25d66007',
4246
+
'aphront-tooltip-css' => '25d66007',
4247
+
'aphront-typeahead-control-css' => '25d66007',
4248
4248
'differential-changeset-view-css' => '8aaacd1b',
4249
4249
'differential-core-view-css' => '8aaacd1b',
4250
4250
'differential-inline-comment-editor' => '27c55b30',
···
4258
4258
'differential-table-of-contents-css' => '8aaacd1b',
4259
4259
'diffusion-commit-view-css' => 'c8ce2d88',
4260
4260
'diffusion-icons-css' => 'c8ce2d88',
4261
-
'global-drag-and-drop-css' => '55644450',
4261
+
'global-drag-and-drop-css' => '25d66007',
4262
4262
'inline-comment-summary-css' => '8aaacd1b',
4263
4263
'javelin-aphlict' => '26980a1c',
4264
4264
'javelin-behavior' => '7d174323',
···
4330
4330
'javelin-util' => '7d174323',
4331
4331
'javelin-vector' => '7d174323',
4332
4332
'javelin-workflow' => '7d174323',
4333
-
'lightbox-attachment-css' => '55644450',
4333
+
'lightbox-attachment-css' => '25d66007',
4334
4334
'maniphest-task-summary-css' => '6b1fccc6',
4335
4335
'maniphest-transaction-detail-css' => '6b1fccc6',
4336
4336
'phabricator-busy' => '26980a1c',
4337
4337
'phabricator-content-source-view-css' => '8aaacd1b',
4338
-
'phabricator-core-buttons-css' => '55644450',
4339
-
'phabricator-core-css' => '55644450',
4340
-
'phabricator-crumbs-view-css' => '55644450',
4341
-
'phabricator-directory-css' => '55644450',
4338
+
'phabricator-core-buttons-css' => '25d66007',
4339
+
'phabricator-core-css' => '25d66007',
4340
+
'phabricator-crumbs-view-css' => '25d66007',
4341
+
'phabricator-directory-css' => '25d66007',
4342
4342
'phabricator-drag-and-drop-file-upload' => '27c55b30',
4343
4343
'phabricator-dropdown-menu' => '26980a1c',
4344
4344
'phabricator-file-upload' => '26980a1c',
4345
-
'phabricator-filetree-view-css' => '55644450',
4346
-
'phabricator-flag-css' => '55644450',
4347
-
'phabricator-form-view-css' => '55644450',
4348
-
'phabricator-header-view-css' => '55644450',
4349
-
'phabricator-jump-nav' => '55644450',
4345
+
'phabricator-filetree-view-css' => '25d66007',
4346
+
'phabricator-flag-css' => '25d66007',
4347
+
'phabricator-form-view-css' => '25d66007',
4348
+
'phabricator-header-view-css' => '25d66007',
4349
+
'phabricator-jump-nav' => '25d66007',
4350
4350
'phabricator-keyboard-shortcut' => '26980a1c',
4351
4351
'phabricator-keyboard-shortcut-manager' => '26980a1c',
4352
-
'phabricator-main-menu-view' => '55644450',
4352
+
'phabricator-main-menu-view' => '25d66007',
4353
4353
'phabricator-menu-item' => '26980a1c',
4354
-
'phabricator-nav-view-css' => '55644450',
4354
+
'phabricator-nav-view-css' => '25d66007',
4355
4355
'phabricator-notification' => '26980a1c',
4356
-
'phabricator-notification-css' => '55644450',
4357
-
'phabricator-notification-menu-css' => '55644450',
4358
-
'phabricator-object-item-list-view-css' => '55644450',
4356
+
'phabricator-notification-css' => '25d66007',
4357
+
'phabricator-notification-menu-css' => '25d66007',
4358
+
'phabricator-object-item-list-view-css' => '25d66007',
4359
4359
'phabricator-object-selector-css' => '8aaacd1b',
4360
4360
'phabricator-phtize' => '26980a1c',
4361
4361
'phabricator-prefab' => '26980a1c',
4362
4362
'phabricator-project-tag-css' => '6b1fccc6',
4363
-
'phabricator-remarkup-css' => '55644450',
4363
+
'phabricator-remarkup-css' => '25d66007',
4364
4364
'phabricator-shaped-request' => '27c55b30',
4365
-
'phabricator-side-menu-view-css' => '55644450',
4366
-
'phabricator-standard-page-view' => '55644450',
4365
+
'phabricator-side-menu-view-css' => '25d66007',
4366
+
'phabricator-standard-page-view' => '25d66007',
4367
4367
'phabricator-textareautils' => '26980a1c',
4368
4368
'phabricator-tooltip' => '26980a1c',
4369
-
'phabricator-transaction-view-css' => '55644450',
4370
-
'phabricator-zindex-css' => '55644450',
4371
-
'sprite-apps-large-css' => '55644450',
4372
-
'sprite-gradient-css' => '55644450',
4373
-
'sprite-icon-css' => '55644450',
4374
-
'sprite-menu-css' => '55644450',
4375
-
'syntax-highlighting-css' => '55644450',
4369
+
'phabricator-transaction-view-css' => '25d66007',
4370
+
'phabricator-zindex-css' => '25d66007',
4371
+
'sprite-apps-large-css' => '25d66007',
4372
+
'sprite-gradient-css' => '25d66007',
4373
+
'sprite-icon-css' => '25d66007',
4374
+
'sprite-menu-css' => '25d66007',
4375
+
'syntax-highlighting-css' => '25d66007',
4376
4376
),
4377
4377
));
+2
src/applications/uiexample/examples/PhabricatorObjectItemListExample.php
+2
src/applications/uiexample/examples/PhabricatorObjectItemListExample.php
···
165
165
$list->addItem(
166
166
id(new PhabricatorObjectItemView())
167
167
->setHeader(pht('Ace of Hearts'))
168
+
->setSubHead(
169
+
pht('This is the most powerful card in the game "Hearts".'))
168
170
->setHref('#')
169
171
->addAttribute(pht('Suit: Hearts'))
170
172
->addAttribute(pht('Rank: Ace'))
+18
src/view/layout/PhabricatorObjectItemView.php
+18
src/view/layout/PhabricatorObjectItemView.php
···
4
4
5
5
private $objectName;
6
6
private $header;
7
+
private $subhead;
7
8
private $href;
8
9
private $attributes = array();
9
10
private $icons = array();
···
58
59
59
60
public function setHeader($header) {
60
61
$this->header = $header;
62
+
return $this;
63
+
}
64
+
65
+
public function setSubHead($subhead) {
66
+
$this->subhead = $subhead;
61
67
return $this;
62
68
}
63
69
···
284
290
$bylines);
285
291
}
286
292
293
+
$subhead = null;
294
+
if ($this->subhead) {
295
+
$subhead = phutil_tag(
296
+
'div',
297
+
array(
298
+
'class' => 'phabricator-object-item-subhead',
299
+
),
300
+
$this->subhead);
301
+
}
302
+
287
303
if ($icons) {
288
304
$icons = phutil_tag(
289
305
'div',
···
315
331
));
316
332
$first = false;
317
333
}
334
+
318
335
$attrs = phutil_tag(
319
336
'ul',
320
337
array(
···
353
370
'class' => implode(' ', $content_classes),
354
371
),
355
372
array(
373
+
$subhead,
356
374
$attrs,
357
375
$this->renderChildren(),
358
376
$foot,
+11
webroot/rsrc/css/layout/phabricator-object-item-list-view.css
+11
webroot/rsrc/css/layout/phabricator-object-item-list-view.css
···
102
102
background: #e9ecf5;
103
103
}
104
104
105
+
/* - Subhead -------------------------------------------------------------------
106
+
107
+
Descriptive Text or Links under the main header, before attributes.
108
+
109
+
*/
110
+
111
+
.phabricator-object-item-subhead {
112
+
color: #777;
113
+
padding: 0 8px 6px;
114
+
}
115
+
105
116
106
117
/* - Attribute List ------------------------------------------------------------
107
118