@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Fix weird gap/spacing on user "Manage" page
Summary: I added this recently for debugging test notifications, but goofed up the markup, thought it was just some weird layout issue, and never got back to it.
Test Plan: {F6063455}
Reviewers: amckinley
Reviewed By: amckinley
Differential Revision: https://secure.phabricator.com/D19892
+8
-11
+8
-11
src/applications/people/controller/PhabricatorPeopleProfileManageController.php
+8
-11
src/applications/people/controller/PhabricatorPeopleProfileManageController.php
···
36
36
$crumbs->addTextCrumb(pht('Manage'));
37
37
$crumbs->setBorder(true);
38
38
39
+
$timeline = $this->buildTransactionTimeline(
40
+
$user,
41
+
new PhabricatorPeopleTransactionQuery());
42
+
$timeline->setShouldTerminate(true);
43
+
39
44
$manage = id(new PHUITwoColumnView())
40
45
->setHeader($header)
41
46
->addClass('project-view-home')
42
47
->addClass('project-view-people-home')
43
48
->setCurtain($curtain)
44
-
->addPropertySection(pht('Details'), $properties);
45
-
46
-
$timeline = $this->buildTransactionTimeline(
47
-
$user,
48
-
new PhabricatorPeopleTransactionQuery());
49
-
$timeline->setShouldTerminate(true);
49
+
->addPropertySection(pht('Details'), $properties)
50
+
->setMainColumn($timeline);
50
51
51
52
return $this->newPage()
52
53
->setTitle(
···
56
57
))
57
58
->setNavigation($nav)
58
59
->setCrumbs($crumbs)
59
-
->appendChild(
60
-
array(
61
-
$manage,
62
-
$timeline,
63
-
));
60
+
->appendChild($manage);
64
61
}
65
62
66
63
private function buildPropertyView(PhabricatorUser $user) {