+1 -1

NOTICE

reviewed

··· 1 1 Phabricator 2 2 Copyright 2014 Phacility, Inc. 3 3 4 4 - This software is primarily developed and maintained by Phacility, Inc. 4 4 + Phabricator was originally developed and maintained by Phacility, Inc. 5 5 6 6 http://www.phacility.com/ 7 7

+10 -10

resources/celerity/map.php

reviewed

··· 10 10 'conpherence.pkg.css' => '0e3cf785', 11 11 'conpherence.pkg.js' => '020aebcf', 12 12 'core.pkg.css' => '0ae696de', 13 13 - 'core.pkg.js' => '68f29322', 13 13 + 'core.pkg.js' => 'd2de90d9', 14 14 'dark-console.pkg.js' => '187792c2', 15 15 'differential.pkg.css' => 'ffb69e3d', 16 16 'differential.pkg.js' => '8deec4cd', ··· 246 246 'rsrc/externals/javelin/ext/view/__tests__/ViewInterpreter.js' => 'a9f35511', 247 247 'rsrc/externals/javelin/ext/view/__tests__/ViewRenderer.js' => '3a1b81f6', 248 248 'rsrc/externals/javelin/lib/Cookie.js' => '05d290ef', 249 249 - 'rsrc/externals/javelin/lib/DOM.js' => '94681e22', 249 249 + 'rsrc/externals/javelin/lib/DOM.js' => 'e4c7622a', 250 250 'rsrc/externals/javelin/lib/History.js' => '030b4f7a', 251 251 'rsrc/externals/javelin/lib/JSON.js' => '541f81c3', 252 252 'rsrc/externals/javelin/lib/Leader.js' => '0d2490ce', ··· 717 717 'javelin-color' => '78f811c9', 718 718 'javelin-cookie' => '05d290ef', 719 719 'javelin-diffusion-locate-file-source' => '94243d89', 720 720 - 'javelin-dom' => '94681e22', 720 720 + 'javelin-dom' => 'e4c7622a', 721 721 'javelin-dynval' => '202a2e85', 722 722 'javelin-event' => 'c03f2fb4', 723 723 'javelin-external-editor-link-engine' => '48a8641f', ··· 1781 1781 'javelin-uri', 1782 1782 'javelin-routable', 1783 1783 ), 1784 1784 - '94681e22' => array( 1785 1785 - 'javelin-magical-init', 1786 1786 - 'javelin-install', 1787 1787 - 'javelin-util', 1788 1788 - 'javelin-vector', 1789 1789 - 'javelin-stratcom', 1790 1790 - ), 1791 1784 '9623adc1' => array( 1792 1785 'javelin-behavior', 1793 1786 'javelin-stratcom', ··· 2166 2159 'javelin-stratcom', 2167 2160 'javelin-dom', 2168 2161 'phuix-dropdown-menu', 2162 2162 + ), 2163 2163 + 'e4c7622a' => array( 2164 2164 + 'javelin-magical-init', 2165 2165 + 'javelin-install', 2166 2166 + 'javelin-util', 2167 2167 + 'javelin-vector', 2168 2168 + 'javelin-stratcom', 2169 2169 ), 2170 2170 'e5bdb730' => array( 2171 2171 'javelin-behavior',

+1 -2

resources/sql/patches/20131004.dxreviewers.php

reviewed

··· 29 29 foreach ($reviewer_phids as $dst) { 30 30 if (phid_get_type($dst) == PhabricatorPHIDConstants::PHID_TYPE_UNKNOWN) { 31 31 // At least one old install ran into some issues here. Skip the row if we 32 32 - // can't figure out what the destination PHID is. See here: 33 33 - // https://github.com/phacility/phabricator/pull/507 32 32 + // can't figure out what the destination PHID is. 34 33 continue; 35 34 } 36 35

-138

scripts/install/install_rhel-derivs.sh

reviewed

··· 1 1 - #!/bin/bash 2 2 - 3 3 - confirm() { 4 4 - echo "Press RETURN to continue, or ^C to cancel."; 5 5 - read -e ignored 6 6 - } 7 7 - 8 8 - RHEL_VER_FILE="/etc/redhat-release" 9 9 - 10 10 - if [[ ! -f $RHEL_VER_FILE ]] 11 11 - then 12 12 - echo "It looks like you're not running a Red Hat-derived distribution." 13 13 - echo "This script is intended to install Phabricator on RHEL-derived" 14 14 - echo "distributions such as RHEL, Fedora, CentOS, and Scientific Linux." 15 15 - echo "Proceed with caution." 16 16 - confirm 17 17 - fi 18 18 - 19 19 - echo "PHABRICATOR RED HAT DERIVATIVE INSTALLATION SCRIPT"; 20 20 - echo "This script will install Phabricator and all of its core dependencies."; 21 21 - echo "Run it from the directory you want to install into."; 22 22 - echo 23 23 - 24 24 - RHEL_REGEX="release ([0-9]+)\." 25 25 - 26 26 - if [[ $(cat $RHEL_VER_FILE) =~ $RHEL_REGEX ]] 27 27 - then 28 28 - RHEL_MAJOR_VER=${BASH_REMATCH[1]} 29 29 - else 30 30 - echo "Ut oh, we were unable to determine your distribution's major" 31 31 - echo "version number. Please make sure you're running 6.0+ before" 32 32 - echo "proceeding." 33 33 - confirm 34 34 - fi 35 35 - 36 36 - if [[ $RHEL_MAJOR_VER < 6 && $RHEL_MAJOR_VER > 0 ]] 37 37 - then 38 38 - echo "** WARNING **" 39 39 - echo "A major version less than 6 was detected. Because of this," 40 40 - echo "several needed dependencies are not available via default repos." 41 41 - echo "Specifically, RHEL 5 does not have a PEAR package for php53-*." 42 42 - echo "We will attempt to install it manually, for APC. Please be careful." 43 43 - confirm 44 44 - fi 45 45 - 46 46 - echo "Phabricator will be installed to: $(pwd)."; 47 47 - confirm 48 48 - 49 49 - echo "Testing sudo/root..." 50 50 - if [[ $EUID -ne 0 ]] # Check if we're root. If we are, continue. 51 51 - then 52 52 - sudo true 53 53 - SUDO="sudo" 54 54 - if [[ $? -ne 0 ]] 55 55 - then 56 56 - echo "ERROR: You must be able to sudo to run this script, or run it as root."; 57 57 - exit 1 58 58 - fi 59 59 - 60 60 - fi 61 61 - 62 62 - if [[ $RHEL_MAJOR_VER == 5 ]] 63 63 - then 64 64 - # RHEL 5's "php" package is actually 5.1. The "php53" package won't let us install php-pecl-apc. 65 65 - # (it tries to pull in php 5.1 stuff) ... 66 66 - yum repolist | grep -i epel 67 67 - if [ $? -ne 0 ]; then 68 68 - echo "It doesn't look like you have the EPEL repo enabled. We are to add it" 69 69 - echo "for you, so that we can install git." 70 70 - $SUDO rpm -Uvh https://download.fedoraproject.org/pub/epel/5/i386/epel-release-5-4.noarch.rpm 71 71 - fi 72 72 - YUMCOMMAND="$SUDO yum install httpd git php53 php53-cli php53-mysql php53-process php53-devel php53-gd gcc wget make pcre-devel mysql-server" 73 73 - else 74 74 - # RHEL 6+ defaults with php 5.3 75 75 - YUMCOMMAND="$SUDO yum install httpd git php php-cli php-mysql php-process php-devel php-gd php-pecl-apc php-pecl-json php-mbstring mysql-server" 76 76 - fi 77 77 - 78 78 - echo "Dropping to yum to install dependencies..." 79 79 - echo "Running: ${YUMCOMMAND}" 80 80 - echo "Yum will prompt you with [Y/n] to continue installing." 81 81 - 82 82 - $YUMCOMMAND 83 83 - 84 84 - if [[ $? -ne 0 ]] 85 85 - then 86 86 - echo "The yum command failed. Please fix the errors and re-run this script." 87 87 - exit 1 88 88 - fi 89 89 - 90 90 - if [[ $RHEL_MAJOR_VER == 5 ]] 91 91 - then 92 92 - # Now that we've ensured all the devel packages required for pecl/apc are there, let's 93 93 - # set up PEAR, and install apc. 94 94 - echo "Attempting to install PEAR" 95 95 - wget https://pear.php.net/go-pear.phar 96 96 - $SUDO php go-pear.phar && $SUDO pecl install apc 97 97 - fi 98 98 - 99 99 - if [[ $? -ne 0 ]] 100 100 - then 101 101 - echo "The apc install failed. Continuing without APC, performance may be impacted." 102 102 - fi 103 103 - 104 104 - pidof httpd 2>&1 > /dev/null 105 105 - if [[ $? -eq 0 ]] 106 106 - then 107 107 - echo "If php was installed above, please run: /etc/init.d/httpd graceful" 108 108 - else 109 109 - echo "Please remember to start the httpd with: /etc/init.d/httpd start" 110 110 - fi 111 111 - 112 112 - pidof mysqld 2>&1 > /dev/null 113 113 - if [[ $? -ne 0 ]] 114 114 - then 115 115 - echo "Please remember to start the mysql server: /etc/init.d/mysqld start" 116 116 - fi 117 117 - 118 118 - confirm 119 119 - 120 120 - if [[ ! -e arcanist ]] 121 121 - then 122 122 - git clone https://github.com/phacility/arcanist.git 123 123 - else 124 124 - (cd arcanist && git pull --rebase) 125 125 - fi 126 126 - 127 127 - if [[ ! -e phabricator ]] 128 128 - then 129 129 - git clone https://github.com/phacility/phabricator.git 130 130 - else 131 131 - (cd phabricator && git pull --rebase) 132 132 - fi 133 133 - 134 134 - echo 135 135 - echo 136 136 - echo "Install probably worked mostly correctly. Continue with the 'Configuration Guide':"; 137 137 - echo 138 138 - echo " https://secure.phabricator.com/book/phabricator/article/configuration_guide/";

-117

scripts/install/install_ubuntu.sh

reviewed

··· 1 1 - #!/bin/bash 2 2 - 3 3 - confirm() { 4 4 - echo "Press RETURN to continue, or ^C to cancel."; 5 5 - read -e ignored 6 6 - } 7 7 - 8 8 - INSTALL_URI=" https://phurl.io/u/install" 9 9 - 10 10 - failed() { 11 11 - echo 12 12 - echo 13 13 - echo "Installation has failed." 14 14 - echo "Text above this message might be useful to understanding what exactly failed." 15 15 - echo 16 16 - echo "Please follow this guide to manually complete installation:" 17 17 - echo 18 18 - echo $INSTALL_URI 19 19 - echo 20 20 - echo "We apologize for the inconvenience." 21 21 - exit 3 22 22 - } 23 23 - 24 24 - ISSUE=`cat /etc/issue` 25 25 - if [[ $ISSUE != Ubuntu* ]] 26 26 - then 27 27 - echo "This script is intended for use on Ubuntu, but this system appears"; 28 28 - echo "to be something else. Your results may vary."; 29 29 - echo 30 30 - confirm 31 31 - fi 32 32 - 33 33 - echo "PHABRICATOR UBUNTU INSTALL SCRIPT"; 34 34 - echo "This script will install Apache, Phabricator and its core dependencies."; 35 35 - echo "Run it from the directory you want to install into."; 36 36 - echo 37 37 - 38 38 - echo "Testing sudo..." 39 39 - sudo true 40 40 - if [ $? -ne 0 ] 41 41 - then 42 42 - echo "ERROR: You must be able to sudo to run this script."; 43 43 - exit 1; 44 44 - fi; 45 45 - 46 46 - echo 'Testing Ubuntu version...' 47 47 - 48 48 - VERSION=`lsb_release -rs` 49 49 - MAJOR=`expr match "$VERSION" '\([0-9]*\)'` 50 50 - 51 51 - if [ "$MAJOR" -lt 16 ] 52 52 - then 53 53 - echo 'This script is intented to install on modern operating systems; Your ' 54 54 - echo 'operating system is too old for this script.' 55 55 - echo 'You can still install Phabricator manually - please consult the installation' 56 56 - echo 'guide to see how:' 57 57 - echo 58 58 - echo $INSTALL_URI 59 59 - echo 60 60 - exit 2 61 61 - fi 62 62 - 63 63 - # Ubuntu 16.04 LTS only has php 7.0 in their repos, so they need this extra ppa. 64 64 - # Ubuntu 17.4 and up have official 7.2 builds. 65 65 - if [ "$MAJOR" -eq 16 ] 66 66 - then 67 67 - echo 'This version of Ubuntu requires additional resources in order to install' 68 68 - echo 'and run Phabricator.' 69 69 - echo 'We will now add a the following package repository to your system:' 70 70 - echo ' https://launchpad.net/~ondrej/+archive/ubuntu/php' 71 71 - echo 72 72 - echo 'This repository is generally considered safe to use.' 73 73 - confirm 74 74 - 75 75 - sudo add-apt-repository -y ppa:ondrej/php || failed 76 76 - fi 77 77 - 78 78 - ROOT=`pwd` 79 79 - echo "Phabricator will be installed to: ${ROOT}."; 80 80 - confirm 81 81 - 82 82 - echo "Installing dependencies: git, apache, mysql, php..."; 83 83 - echo 84 84 - sudo apt-get -qq update 85 85 - sudo apt-get install \ 86 86 - git mysql-server apache2 libapache2-mod-php \ 87 87 - php php-mysql php-gd php-curl php-apcu php-cli php-json php-mbstring \ 88 88 - || failed 89 89 - 90 90 - echo "Enabling mod_rewrite in Apache..." 91 91 - echo 92 92 - sudo a2enmod rewrite || failed 93 93 - 94 94 - echo "Downloading Phabricator and dependencies..." 95 95 - echo 96 96 - 97 97 - if [ ! -e arcanist ] 98 98 - then 99 99 - git clone https://github.com/phacility/arcanist.git 100 100 - else 101 101 - (cd arcanist && git pull --rebase) 102 102 - fi 103 103 - 104 104 - if [ ! -e phabricator ] 105 105 - then 106 106 - git clone https://github.com/phacility/phabricator.git 107 107 - else 108 108 - (cd phabricator && git pull --rebase) 109 109 - fi 110 110 - 111 111 - echo 112 112 - echo 113 113 - echo "Install probably worked mostly correctly. Continue with the 'Configuration Guide':"; 114 114 - echo 115 115 - echo " https://secure.phabricator.com/book/phabricator/article/configuration_guide/"; 116 116 - echo 117 117 - echo 'Next step is "Configuring Apache webserver".'

+1 -1

src/applications/almanac/util/__tests__/AlmanacNamesTestCase.php

reviewed

··· 30 30 31 31 'abc' => true, 32 32 'a.b' => true, 33 33 - 'db.phacility.instance' => true, 33 33 + 'db.companyname.instance' => true, 34 34 'web002.useast.example.com' => true, 35 35 'master.example-corp.com' => true, 36 36

+2 -3

src/applications/base/PhabricatorApplication.php

reviewed

··· 135 135 136 136 137 137 /** 138 138 - * Returns true if an application is first-party (developed by Phacility) 139 139 - * and false otherwise. 138 138 + * Returns true if an application is first-party and false otherwise. 140 139 * 141 141 - * @return bool True if this application is developed by Phacility. 140 140 + * @return bool True if this application is first-party. 142 141 */ 143 142 final public function isFirstParty() { 144 143 $where = id(new ReflectionClass($this))->getFileName();

+5 -1

src/applications/calendar/parser/ics/PhutilICSWriter.php

reviewed

··· 128 128 129 129 $properties[] = $this->newTextProperty( 130 130 'PRODID', 131 131 - '-//Phacility//Phabricator//EN'); 131 131 + self::getICSPRODID()); 132 132 133 133 return $properties; 134 134 + } 135 135 + 136 136 + public static function getICSPRODID() { 137 137 + return '-//Phacility//Phabricator//EN'; 134 138 } 135 139 136 140 private function getEventNodeProperties(PhutilCalendarEventNode $event) {

+6

src/applications/calendar/parser/ics/__tests__/PhutilICSWriterTestCase.php

reviewed

··· 138 138 private function assertICS($name, $actual) { 139 139 $path = dirname(__FILE__).'/data/'.$name; 140 140 $data = Filesystem::readFile($path); 141 141 + 142 142 + $data = str_replace( 143 143 + '${PRODID}', 144 144 + PhutilICSWriter::getICSPRODID(), 145 145 + $data); 146 146 + 141 147 $this->assertEqual($data, $actual, pht('ICS: %s', $name)); 142 148 } 143 149

+1 -1

src/applications/calendar/parser/ics/__tests__/data/writer-christmas.ics

reviewed

··· 1 1 BEGIN:VCALENDAR 2 2 VERSION:2.0 3 3 - PRODID:-//Phacility//Phabricator//EN 3 3 + PRODID:${PRODID} 4 4 BEGIN:VEVENT 5 5 UID:christmas-day 6 6 CREATED:20160901T232425Z

+1 -1

src/applications/calendar/parser/ics/__tests__/data/writer-office-party.ics

reviewed

··· 1 1 BEGIN:VCALENDAR 2 2 VERSION:2.0 3 3 - PRODID:-//Phacility//Phabricator//EN 3 3 + PRODID:${PRODID} 4 4 BEGIN:VEVENT 5 5 UID:office-party 6 6 CREATED:20161001T120000Z

+1 -1

src/applications/calendar/parser/ics/__tests__/data/writer-recurring-christmas.ics

reviewed

··· 1 1 BEGIN:VCALENDAR 2 2 VERSION:2.0 3 3 - PRODID:-//Phacility//Phabricator//EN 3 3 + PRODID:${PRODID} 4 4 BEGIN:VEVENT 5 5 UID:recurring-christmas 6 6 CREATED:20001225T000000Z

+1 -1

src/applications/calendar/parser/ics/__tests__/data/writer-tea-time.ics

reviewed

··· 1 1 BEGIN:VCALENDAR 2 2 VERSION:2.0 3 3 - PRODID:-//Phacility//Phabricator//EN 3 3 + PRODID:${PRODID} 4 4 BEGIN:VEVENT 5 5 UID:tea-time 6 6 CREATED:20160915T070000Z

+3 -3

src/applications/metamta/parser/PhabricatorMetaMTAEmailBodyParser.php

reviewed

··· 11 11 * 12 12 * Or 13 13 * 14 14 - * !assign epriestley 14 14 + * !assign alincoln 15 15 * 16 16 * please, take this task I took; its hard 17 17 * ··· 20 20 * commands. For example, this body above might parse as: 21 21 * 22 22 * array( 23 23 - * 'body' => 'please, take this task I took; its hard', 23 23 + * 'body' => 'please, take this task I took; it's hard', 24 24 * 'commands' => array( 25 25 - * array('assign', 'epriestley'), 25 25 + * array('assign', 'alincoln'), 26 26 * ), 27 27 * ) 28 28 *

-1

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

reviewed

··· 723 723 // This behavior has been reverted, but users who updated between Feb 1, 724 724 // 2012 and Mar 1, 2012 will have the erroring version. Do a dumb test 725 725 // against stdout to check for this possibility. 726 726 - // See: https://github.com/phacility/phabricator/issues/101/ 727 726 728 727 // NOTE: Mercurial has translated versions, which translate this error 729 728 // string. In a translated version, the string will be something else,

+2 -2

src/applications/uiexample/examples/PHUIBadgeExample.php

reviewed

··· 19 19 $badges1 = array(); 20 20 $badges1[] = id(new PHUIBadgeView()) 21 21 ->setIcon('fa-users') 22 22 - ->setHeader(pht('Phacility High Command')) 22 22 + ->setHeader(pht('High Command')) 23 23 ->setHref('/') 24 24 ->setSource('Projects (automatic)') 25 25 ->addByline(pht('Dec 31, 1969')) ··· 113 113 ->setHeader(pht('Lead Developer')) 114 114 ->setSubhead(pht('Lead Developer of Phabricator')) 115 115 ->setQuality(PhabricatorBadgesQuality::HEIRLOOM) 116 116 - ->setSource(pht('Direct Award (epriestley)')) 116 116 + ->setSource(pht('Direct Award')) 117 117 ->addByline(pht('Dec 31, 1969')) 118 118 ->addByline('1 Awarded (0.4%)'); 119 119

+1 -16

src/docs/user/installation_guide.diviner

reviewed

··· 102 102 Installing Required Components 103 103 ============================== 104 104 105 105 - If you are installing on Ubuntu or an RedHat derivative, there are install 106 106 - scripts available which should handle most of the things discussed in this 107 107 - document for you: 108 108 - 109 109 - - **RedHat Derivatives**: 110 110 - [[ https://secure.phabricator.com/diffusion/P/browse/master/scripts/install/install_rhel-derivs.sh 111 111 - | install_rhel-derivs.sh ]] 112 112 - - **Ubuntu**: 113 113 - [[ https://secure.phabricator.com/diffusion/P/browse/master/scripts/install/install_ubuntu.sh 114 114 - | install_ubuntu.sh ]] 115 115 - 116 116 - If those work for you, you can skip directly to the 117 117 - @{article:Configuration Guide}. These scripts are also available in the 118 118 - `scripts/install` directory in the project itself. 119 119 - 120 120 - Otherwise, here's a general description of what you need to install: 105 105 + Here's a general description of what you need to install: 121 106 122 107 - git (usually called "git" in package management systems) 123 108 - Apache (usually "httpd" or "apache2") (or nginx)

+1 -4

src/docs/user/userguide/phame.diviner

reviewed

··· 84 84 85 85 WARNING: This feature is still a prototype and has some known issues. 86 86 87 87 - You can host a Phame blog on an external domain, like `blog.mycompany.com`. The 88 88 - Phacility corporate blog is an example of an external Phame blog: 89 89 - 90 90 - > https://blog.phacility.com/ 87 87 + You can host a Phame blog on an external domain, like `blog.mycompany.com`. 91 88 92 89 External blogs are public (they do not require login) and are only supported if 93 90 your Phabricator install is also public. You can make an install public by

+2 -2

webroot/rsrc/externals/javelin/lib/DOM.js

reviewed

··· 124 124 'will not do the right thing with this.'); 125 125 } 126 126 127 127 - // TODO(epriestley): May need to deny <option> more broadly, see 127 127 + // TODO: May need to deny <option> more broadly, see 128 128 // http://support.microsoft.com/kb/829907 and the whole mess in the 129 129 // heavy stack. But I seem to have gotten away without cloning into the 130 130 // documentFragment below, so this may be a nonissue. ··· 147 147 wrapper.innerHTML = this._content; 148 148 var fragment = document.createDocumentFragment(); 149 149 while (wrapper.firstChild) { 150 150 - // TODO(epriestley): Do we need to do a bunch of cloning junk here? 150 150 + // TODO: Do we need to do a bunch of cloning junk here? 151 151 // See heavy stack. I'm disconnecting the nodes instead; this seems 152 152 // to work but maybe my test case just isn't extensive enough. 153 153 fragment.appendChild(wrapper.removeChild(wrapper.firstChild));