@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Tailor Diffusion protocol rules slightly
Summary: Fixes T10948. Ref T10923. Make these rules a little more thorough and document their behavior.
Test Plan: Looked at Diffusion clone URIs.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10923, T10948
Differential Revision: https://secure.phabricator.com/D15887
+28
-2
+2
-2
src/applications/repository/storage/PhabricatorRepository.php
+2
-2
src/applications/repository/storage/PhabricatorRepository.php
···
2091
2091
// HTTP is not supported for Subversion.
2092
2092
if ($this->isSVN()) {
2093
2093
$has_http = false;
2094
+
$has_https = false;
2094
2095
}
2095
2096
2096
-
// TODO: Maybe allow users to disable this by default somehow?
2097
-
$has_ssh = true;
2097
+
$has_ssh = (bool)strlen(PhabricatorEnv::getEnvConfig('phd.user'));
2098
2098
2099
2099
$protocol_map = array(
2100
2100
PhabricatorRepositoryURI::BUILTIN_PROTOCOL_SSH => $has_ssh,
+26
src/docs/user/userguide/diffusion_uris.diviner
+26
src/docs/user/userguide/diffusion_uris.diviner
···
164
164
repository.
165
165
166
166
167
+
Builtin Clone URIs
168
+
==================
169
+
170
+
By default, Phabricator automatically exposes and activates HTTP, HTTPS and
171
+
SSH clone URIs by examining configuration.
172
+
173
+
**HTTP**: The `http://` clone URI will be available if these conditions are
174
+
satisfied:
175
+
176
+
- `diffusion.allow-http-auth` must be enabled.
177
+
- The repository must be a Git or Mercurial repository.
178
+
- `security.require-https` must be disabled.
179
+
180
+
**HTTPS**: The `https://` clone URI will be available if these conditions are
181
+
satisfied:
182
+
183
+
- `diffusion.allow-http-auth` must be enabled.
184
+
- The repository must be a Git or Mercurial repository.
185
+
- The `phabricator.base-uri` protocol must be `https://`.
186
+
187
+
**SSH**: The `ssh://` or `svn+ssh://` clone URI will be available if these
188
+
conditions are satisfied:
189
+
190
+
- `phd.user` must be configured.
191
+
192
+
167
193
Customizing Displayed Clone URIs
168
194
================================
169
195