@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Define JavaScript functions before they are used
Summary: This should be a fairly minor change that silences a bunch of JSHint warnings.
Test Plan: `arc lint` showed less warnings.
Reviewers: epriestley, #blessed_reviewers
Reviewed By: epriestley, #blessed_reviewers
Subscribers: Korvin, epriestley
Differential Revision: https://secure.phabricator.com/D11064
authored by
Joshua Spence
and committed by
epriestley
558e1ee3
e6684af7
+89
-96
+78
-78
resources/celerity/map.php
+78
-78
resources/celerity/map.php
···
9
9
'names' => array(
10
10
'core.pkg.css' => 'f588bfc3',
11
11
'core.pkg.js' => '2d1f7db1',
12
-
'darkconsole.pkg.js' => 'ac37f0cd',
12
+
'darkconsole.pkg.js' => 'd326843f',
13
13
'differential.pkg.css' => '8af45893',
14
14
'differential.pkg.js' => '42c10e78',
15
15
'diffusion.pkg.css' => '591664fa',
···
348
348
'rsrc/js/application/conpherence/behavior-menu.js' => 'f0a41b9f',
349
349
'rsrc/js/application/conpherence/behavior-pontificate.js' => '85ab3c8e',
350
350
'rsrc/js/application/conpherence/behavior-widget-pane.js' => '40b1ff90',
351
-
'rsrc/js/application/countdown/timer.js' => '361e3ed3',
351
+
'rsrc/js/application/countdown/timer.js' => 'e4cc26b3',
352
352
'rsrc/js/application/dashboard/behavior-dashboard-async-panel.js' => '469c0d9e',
353
353
'rsrc/js/application/dashboard/behavior-dashboard-move-panels.js' => '82439934',
354
354
'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375',
···
381
381
'rsrc/js/application/herald/HeraldRuleEditor.js' => '335fd41f',
382
382
'rsrc/js/application/herald/PathTypeahead.js' => 'f7fc67ec',
383
383
'rsrc/js/application/herald/herald-rule-editor.js' => '7ebaeed3',
384
-
'rsrc/js/application/maniphest/behavior-batch-editor.js' => 'f588412e',
384
+
'rsrc/js/application/maniphest/behavior-batch-editor.js' => 'f24f3253',
385
385
'rsrc/js/application/maniphest/behavior-batch-selector.js' => '7b98d7c5',
386
386
'rsrc/js/application/maniphest/behavior-line-chart.js' => '22e16ae7',
387
387
'rsrc/js/application/maniphest/behavior-list-edit.js' => 'a9f88de2',
···
394
394
'rsrc/js/application/passphrase/phame-credential-control.js' => '3d51a746',
395
395
'rsrc/js/application/phame/phame-post-preview.js' => 'be807912',
396
396
'rsrc/js/application/pholio/behavior-pholio-mock-edit.js' => '9c2623f4',
397
-
'rsrc/js/application/pholio/behavior-pholio-mock-view.js' => '152178f0',
398
-
'rsrc/js/application/phortune/behavior-balanced-payment-form.js' => '3b3e1664',
399
-
'rsrc/js/application/phortune/behavior-stripe-payment-form.js' => '1693a296',
400
-
'rsrc/js/application/phortune/behavior-test-payment-form.js' => 'ab8d2723',
397
+
'rsrc/js/application/pholio/behavior-pholio-mock-view.js' => '9b04250e',
398
+
'rsrc/js/application/phortune/behavior-balanced-payment-form.js' => 'b2c03e60',
399
+
'rsrc/js/application/phortune/behavior-stripe-payment-form.js' => '3f5d6dbf',
400
+
'rsrc/js/application/phortune/behavior-test-payment-form.js' => 'fc91ab6c',
401
401
'rsrc/js/application/phortune/phortune-credit-card-form.js' => '2290aeef',
402
402
'rsrc/js/application/policy/behavior-policy-control.js' => 'f3fef818',
403
403
'rsrc/js/application/policy/behavior-policy-rule-editor.js' => 'fe9a552f',
···
447
447
'rsrc/js/core/behavior-autofocus.js' => '7319e029',
448
448
'rsrc/js/core/behavior-choose-control.js' => '6153c708',
449
449
'rsrc/js/core/behavior-crop.js' => 'fa0f4fc2',
450
-
'rsrc/js/core/behavior-dark-console.js' => '357b6e9b',
450
+
'rsrc/js/core/behavior-dark-console.js' => 'caa97e33',
451
451
'rsrc/js/core/behavior-device.js' => '03d6ed07',
452
452
'rsrc/js/core/behavior-drag-and-drop-textarea.js' => '92eb531d',
453
453
'rsrc/js/core/behavior-error-log.js' => '6882e80a',
···
545
545
'javelin-behavior-aphront-more' => 'a80d0378',
546
546
'javelin-behavior-audio-source' => '59b251eb',
547
547
'javelin-behavior-audit-preview' => 'd835b03a',
548
-
'javelin-behavior-balanced-payment-form' => '3b3e1664',
548
+
'javelin-behavior-balanced-payment-form' => 'b2c03e60',
549
549
'javelin-behavior-boards-dropdown' => '0ec56e1d',
550
550
'javelin-behavior-choose-control' => '6153c708',
551
551
'javelin-behavior-config-reorder-fields' => '14a827de',
552
552
'javelin-behavior-conpherence-menu' => 'f0a41b9f',
553
553
'javelin-behavior-conpherence-pontificate' => '85ab3c8e',
554
554
'javelin-behavior-conpherence-widget-pane' => '40b1ff90',
555
-
'javelin-behavior-countdown-timer' => '361e3ed3',
556
-
'javelin-behavior-dark-console' => '357b6e9b',
555
+
'javelin-behavior-countdown-timer' => 'e4cc26b3',
556
+
'javelin-behavior-dark-console' => 'caa97e33',
557
557
'javelin-behavior-dashboard-async-panel' => '469c0d9e',
558
558
'javelin-behavior-dashboard-move-panels' => '82439934',
559
559
'javelin-behavior-dashboard-query-panel-select' => '453c5375',
···
589
589
'javelin-behavior-lightbox-attachments' => 'f8ba29d7',
590
590
'javelin-behavior-line-chart' => '22e16ae7',
591
591
'javelin-behavior-load-blame' => '42126667',
592
-
'javelin-behavior-maniphest-batch-editor' => 'f588412e',
592
+
'javelin-behavior-maniphest-batch-editor' => 'f24f3253',
593
593
'javelin-behavior-maniphest-batch-selector' => '7b98d7c5',
594
594
'javelin-behavior-maniphest-list-editor' => 'a9f88de2',
595
595
'javelin-behavior-maniphest-subpriority-editor' => '84845b5b',
···
623
623
'javelin-behavior-phabricator-watch-anchor' => '06e05112',
624
624
'javelin-behavior-phame-post-preview' => 'be807912',
625
625
'javelin-behavior-pholio-mock-edit' => '9c2623f4',
626
-
'javelin-behavior-pholio-mock-view' => '152178f0',
626
+
'javelin-behavior-pholio-mock-view' => '9b04250e',
627
627
'javelin-behavior-phui-object-box-tabs' => '2bfa2836',
628
628
'javelin-behavior-phui-timeline-dropdown-menu' => '4d94d9c3',
629
629
'javelin-behavior-policy-control' => 'f3fef818',
···
642
642
'javelin-behavior-search-reorder-queries' => 'e9581f08',
643
643
'javelin-behavior-select-on-click' => '4e3e79a6',
644
644
'javelin-behavior-slowvote-embed' => 'd6f54db0',
645
-
'javelin-behavior-stripe-payment-form' => '1693a296',
646
-
'javelin-behavior-test-payment-form' => 'ab8d2723',
645
+
'javelin-behavior-stripe-payment-form' => '3f5d6dbf',
646
+
'javelin-behavior-test-payment-form' => 'fc91ab6c',
647
647
'javelin-behavior-toggle-class' => 'e566f52c',
648
648
'javelin-behavior-view-placeholder' => '2fa810fc',
649
649
'javelin-behavior-workflow' => '0a3f3021',
···
857
857
'javelin-workflow',
858
858
'phabricator-draggable-list',
859
859
),
860
+
'7319e029' => array(
861
+
'javelin-behavior',
862
+
'javelin-dom',
863
+
),
864
+
'97258e55' => array(
865
+
'javelin-install',
866
+
'javelin-stratcom',
867
+
'javelin-util',
868
+
'javelin-behavior',
869
+
'javelin-json',
870
+
'javelin-dom',
871
+
'javelin-resource',
872
+
'javelin-routable',
873
+
),
860
874
'06e05112' => array(
861
875
'javelin-behavior',
862
876
'javelin-stratcom',
···
935
949
'javelin-request',
936
950
'javelin-util',
937
951
),
938
-
'152178f0' => array(
939
-
'javelin-behavior',
940
-
'javelin-util',
941
-
'javelin-stratcom',
942
-
'javelin-dom',
943
-
'javelin-vector',
944
-
'javelin-magical-init',
945
-
'javelin-request',
946
-
'javelin-history',
947
-
'javelin-workflow',
948
-
'javelin-mask',
949
-
'javelin-behavior-device',
950
-
'phabricator-keyboard-shortcut',
951
-
),
952
-
'1693a296' => array(
953
-
'javelin-behavior',
954
-
'javelin-dom',
955
-
'phortune-credit-card-form',
956
-
),
957
952
'1ae869f2' => array(
958
953
'javelin-install',
959
954
'javelin-util',
···
1028
1023
'javelin-json',
1029
1024
'phabricator-prefab',
1030
1025
),
1031
-
'357b6e9b' => array(
1032
-
'javelin-behavior',
1033
-
'javelin-stratcom',
1034
-
'javelin-util',
1035
-
'javelin-dom',
1036
-
'javelin-request',
1037
-
'phabricator-keyboard-shortcut',
1038
-
),
1039
-
'361e3ed3' => array(
1040
-
'javelin-behavior',
1041
-
'javelin-dom',
1042
-
),
1043
1026
'3ab51e2c' => array(
1044
1027
'javelin-behavior',
1045
1028
'javelin-behavior-device',
···
1048
1031
'javelin-dom',
1049
1032
'javelin-magical-init',
1050
1033
),
1051
-
'3b3e1664' => array(
1052
-
'javelin-behavior',
1053
-
'javelin-dom',
1054
-
'phortune-credit-card-form',
1055
-
),
1056
1034
'3d51a746' => array(
1057
1035
'javelin-behavior',
1058
1036
'javelin-dom',
···
1066
1044
'javelin-behavior-device',
1067
1045
'javelin-stratcom',
1068
1046
'phabricator-tooltip',
1047
+
),
1048
+
'3f5d6dbf' => array(
1049
+
'javelin-behavior',
1050
+
'javelin-dom',
1051
+
'phortune-credit-card-form',
1069
1052
),
1070
1053
'40a6a403' => array(
1071
1054
'javelin-install',
···
1279
1262
'javelin-stratcom',
1280
1263
'phabricator-prefab',
1281
1264
),
1282
-
'7319e029' => array(
1283
-
'javelin-behavior',
1284
-
'javelin-dom',
1285
-
),
1286
1265
'76b9fc3e' => array(
1287
1266
'javelin-behavior',
1288
1267
'javelin-stratcom',
···
1425
1404
'javelin-workflow',
1426
1405
'javelin-util',
1427
1406
),
1428
-
'97258e55' => array(
1407
+
'988040b4' => array(
1429
1408
'javelin-install',
1430
-
'javelin-stratcom',
1431
-
'javelin-util',
1432
-
'javelin-behavior',
1433
-
'javelin-json',
1434
1409
'javelin-dom',
1435
-
'javelin-resource',
1436
-
'javelin-routable',
1410
+
'javelin-reactor-dom',
1437
1411
),
1438
-
'988040b4' => array(
1439
-
'javelin-install',
1412
+
'9b04250e' => array(
1413
+
'javelin-behavior',
1414
+
'javelin-util',
1415
+
'javelin-stratcom',
1440
1416
'javelin-dom',
1441
-
'javelin-reactor-dom',
1417
+
'javelin-vector',
1418
+
'javelin-magical-init',
1419
+
'javelin-request',
1420
+
'javelin-history',
1421
+
'javelin-workflow',
1422
+
'javelin-mask',
1423
+
'javelin-behavior-device',
1424
+
'phabricator-keyboard-shortcut',
1442
1425
),
1443
1426
'9c2623f4' => array(
1444
1427
'javelin-behavior',
···
1536
1519
'javelin-util',
1537
1520
'phabricator-keyboard-shortcut',
1538
1521
),
1539
-
'ab8d2723' => array(
1540
-
'javelin-behavior',
1541
-
'javelin-dom',
1542
-
'phortune-credit-card-form',
1543
-
),
1544
1522
'ad7a69ca' => array(
1545
1523
'javelin-install',
1546
1524
'javelin-util',
···
1558
1536
'javelin-dom',
1559
1537
'javelin-uri',
1560
1538
'javelin-request',
1539
+
),
1540
+
'b2c03e60' => array(
1541
+
'javelin-behavior',
1542
+
'javelin-dom',
1543
+
'phortune-credit-card-form',
1561
1544
),
1562
1545
'b3a4b884' => array(
1563
1546
'javelin-behavior',
···
1671
1654
'javelin-stratcom',
1672
1655
'phabricator-phtize',
1673
1656
),
1657
+
'caa97e33' => array(
1658
+
'javelin-behavior',
1659
+
'javelin-stratcom',
1660
+
'javelin-util',
1661
+
'javelin-dom',
1662
+
'javelin-request',
1663
+
'phabricator-keyboard-shortcut',
1664
+
),
1674
1665
'cc1bd0b0' => array(
1675
1666
'javelin-install',
1676
1667
'javelin-event',
···
1782
1773
'javelin-dom',
1783
1774
'javelin-uri',
1784
1775
),
1776
+
'e4cc26b3' => array(
1777
+
'javelin-behavior',
1778
+
'javelin-dom',
1779
+
),
1785
1780
'e566f52c' => array(
1786
1781
'javelin-behavior',
1787
1782
'javelin-stratcom',
···
1836
1831
'javelin-request',
1837
1832
'javelin-workflow',
1838
1833
),
1834
+
'f24f3253' => array(
1835
+
'javelin-behavior',
1836
+
'javelin-dom',
1837
+
'javelin-util',
1838
+
'phabricator-prefab',
1839
+
'multirow-row-manager',
1840
+
'javelin-json',
1841
+
),
1839
1842
'f36e01af' => array(
1840
1843
'javelin-behavior',
1841
1844
'javelin-behavior-device',
···
1851
1854
'phuix-action-list-view',
1852
1855
'phuix-action-view',
1853
1856
'javelin-workflow',
1854
-
),
1855
-
'f588412e' => array(
1856
-
'javelin-behavior',
1857
-
'javelin-dom',
1858
-
'javelin-util',
1859
-
'phabricator-prefab',
1860
-
'multirow-row-manager',
1861
-
'javelin-json',
1862
1857
),
1863
1858
'f6555212' => array(
1864
1859
'javelin-install',
···
1922
1917
'javelin-dom',
1923
1918
'javelin-vector',
1924
1919
'javelin-magical-init',
1920
+
),
1921
+
'fc91ab6c' => array(
1922
+
'javelin-behavior',
1923
+
'javelin-dom',
1924
+
'phortune-credit-card-form',
1925
1925
),
1926
1926
'fcba4ecc' => array(
1927
1927
'javelin-install',
+1
-3
webroot/rsrc/js/application/countdown/timer.js
+1
-3
webroot/rsrc/js/application/countdown/timer.js
···
5
5
*/
6
6
7
7
JX.behavior('countdown-timer', function(config) {
8
-
9
8
try {
10
9
var container = JX.$(config.container);
11
10
} catch (ignored) {
12
11
return;
13
12
}
14
-
15
-
calculateTimeLeft();
16
13
17
14
function setComponent(which, content) {
18
15
var component = JX.DOM.find(container, '*', 'phabricator-timer-' + which);
···
54
51
setComponent('seconds', [seconds, JX.$N('small', {}, ['.', partial])]);
55
52
}
56
53
54
+
calculateTimeLeft();
57
55
});
+2
-4
webroot/rsrc/js/application/maniphest/behavior-batch-editor.js
+2
-4
webroot/rsrc/js/application/maniphest/behavior-batch-editor.js
···
9
9
*/
10
10
11
11
JX.behavior('maniphest-batch-editor', function(config) {
12
-
13
12
var root = JX.$(config.root);
14
13
var editor_table = JX.DOM.find(root, 'table', 'maniphest-batch-actions');
15
14
var manager = new JX.MultirowRowManager(editor_table);
16
15
var action_rows = [];
17
16
18
-
addRow({});
19
-
20
17
function renderRow() {
21
-
22
18
var action_select = JX.Prefab.renderSelect(
23
19
{
24
20
'add_project': 'Add Projects',
···
118
114
119
115
input.value = JX.JSON.stringify(actions);
120
116
}
117
+
118
+
addRow({});
121
119
122
120
JX.DOM.listen(
123
121
root,
+3
-3
webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js
+3
-3
webroot/rsrc/js/application/pholio/behavior-pholio-mock-view.js
···
700
700
e.kill();
701
701
});
702
702
703
-
JX.Stratcom.listen('click', 'pholio-device-lightbox', lightbox_detach);
704
-
JX.Stratcom.listen('resize', null, lightbox_resize);
705
-
706
703
function lightbox_attach() {
707
704
JX.DOM.alterClass(document.body, 'lightbox-attached', true);
708
705
JX.Mask.show('jx-dark-mask');
···
745
742
JX.Stratcom.addSigil(el, 'pholio-device-lightbox');
746
743
return el;
747
744
}
745
+
746
+
JX.Stratcom.listen('click', 'pholio-device-lightbox', lightbox_detach);
747
+
JX.Stratcom.listen('resize', null, lightbox_resize);
748
748
749
749
750
750
/* -( Preload )------------------------------------------------------------ */
+2
-2
webroot/rsrc/js/application/phortune/behavior-balanced-payment-form.js
+2
-2
webroot/rsrc/js/application/phortune/behavior-balanced-payment-form.js
···
8
8
JX.behavior('balanced-payment-form', function(config) {
9
9
balanced.init(config.balancedMarketplaceURI);
10
10
11
-
var ccform = new JX.PhortuneCreditCardForm(JX.$(config.formID), onsubmit);
12
-
13
11
function onsubmit(card_data) {
14
12
var errors = [];
15
13
···
54
52
55
53
ccform.submitForm(errors, {balancedMarketplaceURI: token});
56
54
}
55
+
56
+
var ccform = new JX.PhortuneCreditCardForm(JX.$(config.formID), onsubmit);
57
57
});
+1
-2
webroot/rsrc/js/application/phortune/behavior-stripe-payment-form.js
+1
-2
webroot/rsrc/js/application/phortune/behavior-stripe-payment-form.js
···
8
8
JX.behavior('stripe-payment-form', function(config) {
9
9
Stripe.setPublishableKey(config.stripePublishableKey);
10
10
11
-
var ccform = new JX.PhortuneCreditCardForm(JX.$(config.formID), onsubmit);
12
-
13
11
function onsubmit(card_data) {
14
12
var errors = [];
15
13
···
54
52
ccform.submitForm(errors, {stripeCardToken: token});
55
53
}
56
54
55
+
var ccform = new JX.PhortuneCreditCardForm(JX.$(config.formID), onsubmit);
57
56
});
+1
-2
webroot/rsrc/js/application/phortune/behavior-test-payment-form.js
+1
-2
webroot/rsrc/js/application/phortune/behavior-test-payment-form.js
···
6
6
*/
7
7
8
8
JX.behavior('test-payment-form', function(config) {
9
-
var ccform = new JX.PhortuneCreditCardForm(JX.$(config.formID), onsubmit);
10
-
11
9
function onsubmit() {
12
10
onresponse();
13
11
}
···
16
14
ccform.submitForm([], {test: true});
17
15
}
18
16
17
+
var ccform = new JX.PhortuneCreditCardForm(JX.$(config.formID), onsubmit);
19
18
});
+1
-2
webroot/rsrc/js/core/behavior-dark-console.js
+1
-2
webroot/rsrc/js/core/behavior-dark-console.js