recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Fix a bad method call signature throwing exceptions in newer Node

Summary:
Ref T13222. See PHI996. Ref T10743. For context, perhaps see T12171.

Node changed some signatures, behaviors, and error handling here in recent versions. As far as I can tell:

- The `script.runInNewContext(...)` method has never taken a `path` parameter, and passing the path has always been wrong.
- The `script.runInNewContext(...)` method started taking an `[options]` parameter at some point, and validating it, so the bad `path` parameter now throws.
- `vm.createScript(...)` is "soft deprecated" but basically fine, and keeping it looks more compatible.

This seems like the smallest and most compatible correct change.

Test Plan: Under Node 10, started Aphlict. Before: fatal error on bad `options` parameter to `runInNewContext()` (expected dictionary). After: notification server starts.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13222, T10743

Differential Revision: https://secure.phabricator.com/D19860

epriestley 55a1ef33 508df60a

+2 -2
+1 -1
resources/celerity/map.php
··· 214 214 'rsrc/externals/javelin/core/__tests__/stratcom.js' => '88bf7313', 215 215 'rsrc/externals/javelin/core/__tests__/util.js' => 'e251703d', 216 216 'rsrc/externals/javelin/core/init.js' => '8d83d2a1', 217 - 'rsrc/externals/javelin/core/init_node.js' => 'c234aded', 217 + 'rsrc/externals/javelin/core/init_node.js' => 'f7732951', 218 218 'rsrc/externals/javelin/core/install.js' => '05270951', 219 219 'rsrc/externals/javelin/core/util.js' => '93cc50d6', 220 220 'rsrc/externals/javelin/docs/Base.js' => '74676256',
+1 -1
webroot/rsrc/externals/javelin/core/init_node.js
··· 49 49 } 50 50 51 51 vm.createScript(content, path) 52 - .runInNewContext(sandbox, path); 52 + .runInNewContext(sandbox); 53 53 }; 54 54 55 55 exports.JX = JX;