recaptime.dev / phorge
@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge
phorge phabricator
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Some ReleephRequests don't have diffs

Summary: Not every commit requested in Releeph has to have come from a Differential revision. If you have a Releeph request for a commit without a Differential revision, you currently get this lovely error in the logs: {P824}. This diff silences the howling.

Test Plan: Load a Releeph branch page; observe log silence.

Reviewers: wez, epriestley

Reviewed By: epriestley

CC: epriestley, aran, SEJeff, Korvin

Differential Revision: https://secure.phabricator.com/D5823

Edward Speyer 55c3c6cb 380f011f

+4
+4
src/applications/releeph/storage/ReleephRequest.php
··· 274 274 } 275 275 276 276 public function loadDifferentialRevision() { 277 + $diff_phid = $this->loadRequestCommitDiffPHID(); 278 + if (!$diff_phid) { 279 + return null; 280 + } 277 281 return $this->loadOneRelative( 278 282 new DifferentialRevision(), 279 283 'phid',