@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
New icons, colors for per reviewer status
Summary: Fixes T10906, Fixes T10820. Adds new icons, grey-er colors for previous states. Also, I think fixed a few bugs?
Test Plan: Fake each state, verify icon is as intended.
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Maniphest Tasks: T10820, T10906
Differential Revision: https://secure.phabricator.com/D15830
+21
-17
+3
-3
resources/celerity/map.php
+3
-3
resources/celerity/map.php
···
7
7
*/
8
8
return array(
9
9
'names' => array(
10
-
'core.pkg.css' => 'b729f9f5',
10
+
'core.pkg.css' => 'dd240688',
11
11
'core.pkg.js' => '6972d365',
12
12
'darkconsole.pkg.js' => 'e7393ebb',
13
13
'differential.pkg.css' => '7ba78475',
···
153
153
'rsrc/css/phui/phui-remarkup-preview.css' => '1a8f2591',
154
154
'rsrc/css/phui/phui-segment-bar-view.css' => '46342871',
155
155
'rsrc/css/phui/phui-spacing.css' => '042804d6',
156
-
'rsrc/css/phui/phui-status.css' => '37309046',
156
+
'rsrc/css/phui/phui-status.css' => 'd5263e49',
157
157
'rsrc/css/phui/phui-tag-view.css' => '6bbd83e2',
158
158
'rsrc/css/phui/phui-timeline-view.css' => '6e342216',
159
159
'rsrc/css/phui/phui-two-column-view.css' => 'b9538af1',
···
848
848
'phui-remarkup-preview-css' => '1a8f2591',
849
849
'phui-segment-bar-view-css' => '46342871',
850
850
'phui-spacing-css' => '042804d6',
851
-
'phui-status-list-view-css' => '37309046',
851
+
'phui-status-list-view-css' => 'd5263e49',
852
852
'phui-tag-view-css' => '6bbd83e2',
853
853
'phui-theme-css' => '027ba77e',
854
854
'phui-timeline-view-css' => '6e342216',
+10
-9
src/applications/differential/view/DifferentialReviewersView.php
+10
-9
src/applications/differential/view/DifferentialReviewersView.php
···
58
58
} else {
59
59
$item->setIcon(
60
60
PHUIStatusItemView::ICON_ACCEPT,
61
-
'dark',
61
+
'bluegrey',
62
62
pht('Accepted Prior Diff'));
63
63
}
64
64
break;
65
65
66
66
case DifferentialReviewerStatus::STATUS_ACCEPTED_OLDER:
67
67
$item->setIcon(
68
-
PHUIStatusItemView::ICON_ACCEPT,
69
-
'dark',
68
+
'fa-check-circle-o',
69
+
'bluegrey',
70
70
pht('Accepted Prior Diff'));
71
71
break;
72
72
···
78
78
pht('Requested Changes'));
79
79
} else {
80
80
$item->setIcon(
81
-
PHUIStatusItemView::ICON_REJECT,
82
-
'dark',
81
+
'fa-times-circle-o',
82
+
'bluegrey',
83
83
pht('Requested Changes to Prior Diff'));
84
84
}
85
85
break;
86
86
87
87
case DifferentialReviewerStatus::STATUS_REJECTED_OLDER:
88
88
$item->setIcon(
89
-
PHUIStatusItemView::ICON_REJECT,
90
-
'dark',
89
+
'fa-times-circle-o',
90
+
'bluegrey',
91
91
pht('Rejected Prior Diff'));
92
92
break;
93
93
94
94
case DifferentialReviewerStatus::STATUS_COMMENTED:
95
95
if ($is_current) {
96
96
$item->setIcon(
97
-
PHUIStatusItemView::ICON_INFO,
97
+
'fa-question-circle',
98
98
'blue',
99
99
pht('Commented'));
100
100
} else {
101
101
$item->setIcon(
102
-
'info-dark',
102
+
'fa-question-circle-o',
103
+
'bluegrey',
103
104
pht('Commented Previously'));
104
105
}
105
106
break;
+8
-5
webroot/rsrc/css/phui/phui-status.css
+8
-5
webroot/rsrc/css/phui/phui-status.css
···
13
13
}
14
14
15
15
.phui-status-item-target {
16
-
padding: 0 12px 0 0;
17
-
line-height: 20px;
16
+
padding: 1px 8px;
18
17
white-space: nowrap;
19
18
}
20
19
···
22
21
width: 100%;
23
22
color: {$greytext};
24
23
line-height: 14px;
25
-
padding: 3px 0;
24
+
padding: 3px 4px;
26
25
}
27
26
28
27
.phui-status-item-highlighted td {
29
-
background-color: {$lightyellow};
28
+
background-color: {$sh-yellowbackground};
29
+
border-radius: 3px;
30
+
}
31
+
32
+
.phui-status-list-view td a {
33
+
color: {$darkbluetext};
30
34
}
31
35
32
36
.phui-status-item-highlighted td.phui-status-item-note {
33
37
background-color: transparent;
34
-
padding-left: 4px;
35
38
}