@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Allow file comments to be edited
Summary:
Fixes T10750. Files have some outdated cache/key code which prevents recording an edit history on file comments.
Remove this ancient cruft.
(Users must `bin/storage adjust` after upgrading to this patch to reap the benefits.)
Test Plan:
- Ran `bin/storage adjust`.
- Edited a comment in Files.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T10750
Differential Revision: https://secure.phabricator.com/D16312
-16
-16
src/applications/files/storage/PhabricatorFileTransactionComment.php
-16
src/applications/files/storage/PhabricatorFileTransactionComment.php
···
7
7
return new PhabricatorFileTransaction();
8
8
}
9
9
10
-
public function shouldUseMarkupCache($field) {
11
-
// Only cache submitted comments.
12
-
return ($this->getTransactionPHID() != null);
13
-
}
14
-
15
-
protected function getConfiguration() {
16
-
$config = parent::getConfiguration();
17
-
$config[self::CONFIG_KEY_SCHEMA] = array(
18
-
'key_draft' => array(
19
-
'columns' => array('authorPHID', 'transactionPHID'),
20
-
'unique' => true,
21
-
),
22
-
) + $config[self::CONFIG_KEY_SCHEMA];
23
-
return $config;
24
-
}
25
-
26
10
}