@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Provide a more tailored error message when a Herald rule fails because of PCRE limits
Summary: Ref T13100. Since rules may begin failing for PRCE configuration reasons soon, provide a more complete explanation of possible causes in the UI.
Test Plan: Faked this, hit it via test console, saw explanation in web UI.
Maniphest Tasks: T13100
Differential Revision: https://secure.phabricator.com/D19178
+7
-1
+7
-1
src/applications/herald/adapter/HeraldAdapter.php
+7
-1
src/applications/herald/adapter/HeraldAdapter.php
···
490
490
$result = @preg_match($condition_value.'S', $value);
491
491
if ($result === false) {
492
492
throw new HeraldInvalidConditionException(
493
-
pht('Regular expression is not valid!'));
493
+
pht(
494
+
'Regular expression "%s" in Herald rule "%s" is not valid, '.
495
+
'or exceeded backtracking or recursion limits while '.
496
+
'executing. Verify the expression and correct it or rewrite '.
497
+
'it with less backtracking.',
498
+
$condition_value,
499
+
$rule->getMonogram()));
494
500
}
495
501
if ($result) {
496
502
return $result_if_match;