@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Modularize Conpherence notification preferences
Summary:
Ref T4103. This is a weird standalone setting that I didn't clean up earlier.
Also fix an issue with the PronounSetting and the Editor not interacting properly.
Test Plan: Edited using new EditEngine UI.
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T4103
Differential Revision: https://secure.phabricator.com/D16014
+39
+2
src/__phutil_library_map__.php
+2
src/__phutil_library_map__.php
···
2145
2145
'PhabricatorConfigVersionsModule' => 'applications/config/module/PhabricatorConfigVersionsModule.php',
2146
2146
'PhabricatorConfigWelcomeController' => 'applications/config/controller/PhabricatorConfigWelcomeController.php',
2147
2147
'PhabricatorConpherenceApplication' => 'applications/conpherence/application/PhabricatorConpherenceApplication.php',
2148
+
'PhabricatorConpherenceNotificationsSetting' => 'applications/settings/setting/PhabricatorConpherenceNotificationsSetting.php',
2148
2149
'PhabricatorConpherencePreferencesSettingsPanel' => 'applications/settings/panel/PhabricatorConpherencePreferencesSettingsPanel.php',
2149
2150
'PhabricatorConpherenceThreadPHIDType' => 'applications/conpherence/phid/PhabricatorConpherenceThreadPHIDType.php',
2150
2151
'PhabricatorConsoleApplication' => 'applications/console/application/PhabricatorConsoleApplication.php',
···
6676
6677
'PhabricatorConfigVersionsModule' => 'PhabricatorConfigModule',
6677
6678
'PhabricatorConfigWelcomeController' => 'PhabricatorConfigController',
6678
6679
'PhabricatorConpherenceApplication' => 'PhabricatorApplication',
6680
+
'PhabricatorConpherenceNotificationsSetting' => 'PhabricatorSelectSetting',
6679
6681
'PhabricatorConpherencePreferencesSettingsPanel' => 'PhabricatorSettingsPanel',
6680
6682
'PhabricatorConpherenceThreadPHIDType' => 'PhabricatorPHIDType',
6681
6683
'PhabricatorConsoleApplication' => 'PhabricatorApplication',
+6
src/applications/settings/editor/PhabricatorUserPreferencesEditor.php
+6
src/applications/settings/editor/PhabricatorUserPreferencesEditor.php
···
99
99
$actor = $this->getActor();
100
100
$settings = PhabricatorSetting::getAllEnabledSettings($actor);
101
101
102
+
foreach ($settings as $key => $setting) {
103
+
$setting = clone $setting;
104
+
$setting->setViewer($actor);
105
+
$settings[$key] = $setting;
106
+
}
107
+
102
108
switch ($type) {
103
109
case PhabricatorUserPreferencesTransaction::TYPE_SETTING:
104
110
foreach ($xactions as $xaction) {
+31
src/applications/settings/setting/PhabricatorConpherenceNotificationsSetting.php
+31
src/applications/settings/setting/PhabricatorConpherenceNotificationsSetting.php
···
1
+
<?php
2
+
3
+
final class PhabricatorConpherenceNotificationsSetting
4
+
extends PhabricatorSelectSetting {
5
+
6
+
const SETTINGKEY = 'conph-notifications';
7
+
8
+
const VALUE_CONPHERENCE_EMAIL = '0';
9
+
const VALUE_CONPHERENCE_NOTIFY = '1';
10
+
11
+
public function getSettingName() {
12
+
return pht('Conpherence Notifications');
13
+
}
14
+
15
+
protected function getControlInstructions() {
16
+
return pht(
17
+
'Choose the default notification behavior for Conpherence rooms.');
18
+
}
19
+
20
+
public function getSettingDefaultValue() {
21
+
return self::VALUE_CONPHERENCE_EMAIL;
22
+
}
23
+
24
+
protected function getSelectOptions() {
25
+
return array(
26
+
self::VALUE_CONPHERENCE_EMAIL => pht('Send Email'),
27
+
self::VALUE_CONPHERENCE_NOTIFY => pht('Send Notifications'),
28
+
);
29
+
}
30
+
31
+
}