allow phids other than users (i.e. mailinglists)

@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.) hq.recaptime.dev/wiki/Phorge

phorge phabricator

fork

Summary:
Via the UI adding a mailinglist for CC works, but via
the API currently it shows:

>One or more PHIDs were invalid for ccPHIDS

This removes the user validation check for ccPHIDs.

(I left it in for other things like owner since that seems
still appropriate?)

Test Plan:
used arc locally to add a mailinglist to cc

```echo '{"id": 2, "ccPHIDs": ["PHID-MLST-ohduchbv4dfimk7opt3r"]}' | arc call-conduit maniphest.update```

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D10193

authored by

cpettet and committed by

epriestley 12 years ago 57eb3aec 59a85e88

-4

1 changed file

expand all

src

applications

maniphest

conduit

ManiphestConduitAPIMethod.php

-4

src/applications/maniphest/conduit/ManiphestConduitAPIMethod.php

··· 109 109 110 110 $ccs = $request->getValue('ccPHIDs'); 111 111 if ($ccs !== null) { 112 - $this->validatePHIDList( 113 - $ccs, 114 - PhabricatorPeopleUserPHIDType::TYPECONST, 115 - 'ccPHIDS'); 116 112 $changes[ManiphestTransaction::TYPE_CCS] = $ccs; 117 113 } 118 114

Configure Feed

Configure Feed