@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Update Help for newPage
Summary: Swaps over to `newPage` and `newDialog`
Test Plan: Unsure how to actually pull these up?
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15617
+6
-17
+4
-8
src/applications/help/controller/PhabricatorHelpDocumentationController.php
+4
-8
src/applications/help/controller/PhabricatorHelpDocumentationController.php
···
38
38
$crumbs = $this->buildApplicationCrumbs();
39
39
$crumbs->addTextCrumb($title);
40
40
41
-
return $this->buildApplicationPage(
42
-
array(
43
-
$crumbs,
44
-
$list,
45
-
),
46
-
array(
47
-
'title' => $title,
48
-
));
41
+
return $this->newPage()
42
+
->setTitle($title)
43
+
->setCrumbs($crumbs)
44
+
->appendChild($list);
49
45
}
50
46
51
47
+1
-5
src/applications/help/controller/PhabricatorHelpEditorProtocolController.php
+1
-5
src/applications/help/controller/PhabricatorHelpEditorProtocolController.php
···
10
10
public function handleRequest(AphrontRequest $request) {
11
11
$viewer = $request->getViewer();
12
12
13
-
$dialog = id(new AphrontDialogView())
14
-
->setUser($viewer)
13
+
return $this->newDialog()
15
14
->setMethod('GET')
16
15
->setSubmitURI('/settings/panel/display/')
17
16
->setTitle(pht('Unsupported Editor Protocol'))
···
24
23
phutil_tag('tt', array(), 'uri.allowed-editor-protocols')))
25
24
->addSubmitButton(pht('Change Settings'))
26
25
->addCancelButton('/');
27
-
28
-
return id(new AphrontDialogResponse())
29
-
->setDialog($dialog);
30
26
}
31
27
32
28
public static function hasAllowedProtocol($uri) {
+1
-4
src/applications/help/controller/PhabricatorHelpKeyboardShortcutController.php
+1
-4
src/applications/help/controller/PhabricatorHelpKeyboardShortcutController.php
···
57
57
array('class' => 'keyboard-shortcut-help'),
58
58
$rows);
59
59
60
-
$dialog = id(new AphrontDialogView())
61
-
->setUser($viewer)
60
+
return $this->newDialog()
62
61
->setTitle(pht('Keyboard Shortcuts'))
63
62
->appendChild($table)
64
63
->addCancelButton('#', pht('Close'));
65
64
66
-
return id(new AphrontDialogResponse())
67
-
->setDialog($dialog);
68
65
}
69
66
70
67
}