+19 -28

resources/celerity/map.php

reviewed

··· 13 13 'core.pkg.js' => '2ff7879f', 14 14 'darkconsole.pkg.js' => '1f9a31bc', 15 15 'differential.pkg.css' => '58712637', 16 16 - 'differential.pkg.js' => '6375358e', 16 16 + 'differential.pkg.js' => 'e6129b80', 17 17 'diffusion.pkg.css' => 'b93d9b8c', 18 18 'diffusion.pkg.js' => '84c8f8fd', 19 19 'favicon.ico' => '30672e08', ··· 390 390 'rsrc/js/application/dashboard/behavior-dashboard-move-panels.js' => '408bf173', 391 391 'rsrc/js/application/dashboard/behavior-dashboard-query-panel-select.js' => '453c5375', 392 392 'rsrc/js/application/dashboard/behavior-dashboard-tab-panel.js' => 'd4eecc63', 393 393 - 'rsrc/js/application/diff/DiffChangeset.js' => '4c9c47ad', 394 394 - 'rsrc/js/application/diff/DiffChangesetList.js' => '589a30aa', 393 393 + 'rsrc/js/application/diff/DiffChangeset.js' => '3d4b3c5e', 394 394 + 'rsrc/js/application/diff/DiffChangesetList.js' => 'e2c315d9', 395 395 'rsrc/js/application/diff/DiffInline.js' => '98c12b2f', 396 396 'rsrc/js/application/diff/behavior-preview-link.js' => '051c7832', 397 397 'rsrc/js/application/differential/behavior-comment-jump.js' => '4fdb476d', 398 398 'rsrc/js/application/differential/behavior-comment-preview.js' => 'b064af76', 399 399 'rsrc/js/application/differential/behavior-diff-radios.js' => 'e1ff79b1', 400 400 'rsrc/js/application/differential/behavior-edit-inline-comments.js' => '89d11432', 401 401 - 'rsrc/js/application/differential/behavior-keyboard-nav.js' => '92904457', 402 401 'rsrc/js/application/differential/behavior-populate.js' => '5e41c819', 403 402 'rsrc/js/application/differential/behavior-toggle-files.js' => 'ca3f91eb', 404 403 'rsrc/js/application/differential/behavior-user-select.js' => 'a8d8459d', ··· 624 623 'javelin-behavior-differential-diff-radios' => 'e1ff79b1', 625 624 'javelin-behavior-differential-edit-inline-comments' => '89d11432', 626 625 'javelin-behavior-differential-feedback-preview' => 'b064af76', 627 627 - 'javelin-behavior-differential-keyboard-navigation' => '92904457', 628 626 'javelin-behavior-differential-populate' => '5e41c819', 629 627 'javelin-behavior-differential-toggle-files' => 'ca3f91eb', 630 628 'javelin-behavior-differential-user-select' => 'a8d8459d', ··· 783 781 'phabricator-darklog' => 'c8e1ffe3', 784 782 'phabricator-darkmessage' => 'c48cccdd', 785 783 'phabricator-dashboard-css' => 'fe5b1869', 786 786 - 'phabricator-diff-changeset' => '4c9c47ad', 787 787 - 'phabricator-diff-changeset-list' => '589a30aa', 784 784 + 'phabricator-diff-changeset' => '3d4b3c5e', 785 785 + 'phabricator-diff-changeset-list' => 'e2c315d9', 788 786 'phabricator-diff-inline' => '98c12b2f', 789 787 'phabricator-drag-and-drop-file-upload' => '58dea2fa', 790 788 'phabricator-draggable-list' => 'bea6e7f4', ··· 1160 1158 'javelin-util', 1161 1159 'javelin-uri', 1162 1160 ), 1161 1161 + '3d4b3c5e' => array( 1162 1162 + 'javelin-dom', 1163 1163 + 'javelin-util', 1164 1164 + 'javelin-stratcom', 1165 1165 + 'javelin-install', 1166 1166 + 'javelin-workflow', 1167 1167 + 'javelin-router', 1168 1168 + 'javelin-behavior-device', 1169 1169 + 'javelin-vector', 1170 1170 + 'phabricator-diff-inline', 1171 1171 + ), 1163 1172 '3dbf94d5' => array( 1164 1173 'javelin-behavior', 1165 1174 'javelin-dom', ··· 1270 1279 'javelin-uri', 1271 1280 'phabricator-notification', 1272 1281 ), 1273 1273 - '4c9c47ad' => array( 1274 1274 - 'javelin-dom', 1275 1275 - 'javelin-util', 1276 1276 - 'javelin-stratcom', 1277 1277 - 'javelin-install', 1278 1278 - 'javelin-workflow', 1279 1279 - 'javelin-router', 1280 1280 - 'javelin-behavior-device', 1281 1281 - 'javelin-vector', 1282 1282 - 'phabricator-diff-inline', 1283 1283 - ), 1284 1282 '4d863052' => array( 1285 1283 'javelin-dom', 1286 1284 'javelin-util', ··· 1348 1346 'javelin-vector', 1349 1347 'javelin-dom', 1350 1348 ), 1351 1351 - '589a30aa' => array( 1352 1352 - 'javelin-install', 1353 1353 - ), 1354 1349 '58dea2fa' => array( 1355 1350 'javelin-install', 1356 1351 'javelin-util', ··· 1629 1624 'javelin-dom', 1630 1625 'javelin-request', 1631 1626 ), 1632 1632 - 92904457 => array( 1633 1633 - 'javelin-behavior', 1634 1634 - 'javelin-dom', 1635 1635 - 'javelin-stratcom', 1636 1636 - 'phabricator-keyboard-shortcut', 1637 1637 - ), 1638 1627 '92b9ec77' => array( 1639 1628 'javelin-behavior', 1640 1629 'javelin-stratcom', ··· 2119 2108 'javelin-stratcom', 2120 2109 'javelin-dom', 2121 2110 ), 2111 2111 + 'e2c315d9' => array( 2112 2112 + 'javelin-install', 2113 2113 + ), 2122 2114 'e2e0a072' => array( 2123 2115 'javelin-behavior', 2124 2116 'javelin-stratcom', ··· 2440 2432 'javelin-behavior-differential-populate', 2441 2433 'javelin-behavior-differential-diff-radios', 2442 2434 'javelin-behavior-differential-comment-jump', 2443 2443 - 'javelin-behavior-differential-keyboard-navigation', 2444 2435 'javelin-behavior-aphront-drag-and-drop-textarea', 2445 2436 'javelin-behavior-phabricator-object-selector', 2446 2437 'javelin-behavior-repository-crossreference',

-1

resources/celerity/packages.php

reviewed

··· 197 197 'javelin-behavior-differential-populate', 198 198 'javelin-behavior-differential-diff-radios', 199 199 'javelin-behavior-differential-comment-jump', 200 200 - 'javelin-behavior-differential-keyboard-navigation', 201 200 'javelin-behavior-aphront-drag-and-drop-textarea', 202 201 'javelin-behavior-phabricator-object-selector', 203 202 'javelin-behavior-repository-crossreference',

-1

src/applications/differential/controller/DifferentialRevisionViewController.php

reviewed

··· 465 465 } 466 466 467 467 Javelin::initBehavior('differential-user-select'); 468 468 - Javelin::initBehavior('differential-keyboard-navigation'); 469 468 470 469 $view = id(new PHUITwoColumnView()) 471 470 ->setHeader($header)

+10

src/applications/differential/view/DifferentialChangesetListView.php

reviewed

··· 234 234 'Highlight As...' => pht('Highlight As...'), 235 235 236 236 'Loading...' => pht('Loading...'), 237 237 + 238 238 + 'Jump to next change.' => pht('Jump to next change.'), 239 239 + 'Jump to previous change.' => pht('Jump to previous change.'), 240 240 + 'Jump to next file.' => pht('Jump to next file.'), 241 241 + 'Jump to previous file.' => pht('Jump to previous file.'), 242 242 + 'Jump to next inline comment.' => pht('Jump to next inline comment.'), 243 243 + 'Jump to previous inline comment.' => 244 244 + pht('Jump to previous inline comment.'), 245 245 + 'Jump to the table of contents.' => 246 246 + pht('Jump to the table of contents.'), 237 247 ), 238 248 )); 239 249

-2

src/applications/diffusion/controller/DiffusionCommitController.php

reviewed

··· 720 720 $request = $this->getRequest(); 721 721 $viewer = $request->getUser(); 722 722 723 723 - Javelin::initBehavior('differential-keyboard-navigation'); 724 724 - 725 723 // TODO: This is pretty awkward, unify the CSS between Diffusion and 726 724 // Differential better. 727 725 require_celerity_resource('differential-core-view-css');

+82

webroot/rsrc/js/application/diff/DiffChangeset.js

reviewed

··· 318 318 return this._highlight; 319 319 }, 320 320 321 321 + getSelectableItems: function() { 322 322 + var items = []; 323 323 + 324 324 + items.push({ 325 325 + type: 'file', 326 326 + changeset: this, 327 327 + target: this, 328 328 + nodes: { 329 329 + begin: this._node, 330 330 + end: null 331 331 + } 332 332 + }); 333 333 + 334 334 + var rows = JX.DOM.scry(this._node, 'tr'); 335 335 + 336 336 + var blocks = []; 337 337 + var block; 338 338 + var ii; 339 339 + for (ii = 0; ii < rows.length; ii++) { 340 340 + var type = this._getRowType(rows[ii]); 341 341 + 342 342 + if (!block || (block.type !== type)) { 343 343 + block = { 344 344 + type: type, 345 345 + items: [] 346 346 + }; 347 347 + blocks.push(block); 348 348 + } 349 349 + 350 350 + block.items.push(rows[ii]); 351 351 + } 352 352 + 353 353 + for (ii = 0; ii < blocks.length; ii++) { 354 354 + block = blocks[ii]; 355 355 + 356 356 + if (block.type == 'change') { 357 357 + items.push({ 358 358 + type: block.type, 359 359 + changeset: this, 360 360 + target: block.items[0], 361 361 + nodes: { 362 362 + begin: block.items[0], 363 363 + end: block.items[block.items.length - 1] 364 364 + } 365 365 + }); 366 366 + } 367 367 + 368 368 + if (block.type == 'comment') { 369 369 + for (var jj = 0; jj < block.items.length; jj++) { 370 370 + items.push({ 371 371 + type: block.type, 372 372 + changeset: this, 373 373 + target: block.items[jj], 374 374 + nodes: { 375 375 + begin: block.items[jj], 376 376 + end: block.items[jj] 377 377 + } 378 378 + }); 379 379 + } 380 380 + } 381 381 + } 382 382 + 383 383 + return items; 384 384 + }, 385 385 + 386 386 + _getRowType: function(row) { 387 387 + // NOTE: Don't do "className.indexOf()" elsewhere. This is evil legacy 388 388 + // magic. 389 389 + 390 390 + if (row.className.indexOf('inline') !== -1) { 391 391 + return 'comment'; 392 392 + } 393 393 + 394 394 + var cells = JX.DOM.scry(row, 'td'); 395 395 + for (var ii = 0; ii < cells.length; ii++) { 396 396 + if (cells[ii].className.indexOf('old') !== -1 || 397 397 + cells[ii].className.indexOf('new') !== -1) { 398 398 + return 'change'; 399 399 + } 400 400 + } 401 401 + }, 402 402 + 321 403 _getNodeData: function() { 322 404 return JX.Stratcom.getData(this._node); 323 405 },

+162

webroot/rsrc/js/application/diff/DiffChangesetList.js

reviewed

··· 55 55 }, 56 56 57 57 members: { 58 58 + _initialized: false, 58 59 _asleep: true, 59 60 _changesets: null, 61 61 + 62 62 + _cursorItem: null, 63 63 + _lastKeyboardManager: null, 60 64 61 65 sleep: function() { 62 66 this._asleep = true; ··· 64 68 65 69 wake: function() { 66 70 this._asleep = false; 71 71 + 72 72 + if (this._initialized) { 73 73 + return; 74 74 + } 75 75 + 76 76 + this._initialized = true; 77 77 + var pht = this.getTranslations(); 78 78 + 79 79 + var label; 80 80 + 81 81 + label = pht('Jump to next change.'); 82 82 + this._installJumpKey('j', label, 1); 83 83 + 84 84 + label = pht('Jump to previous change.'); 85 85 + this._installJumpKey('k', label, -1); 86 86 + 87 87 + label = pht('Jump to next file.'); 88 88 + this._installJumpKey('J', label, 1, 'file'); 89 89 + 90 90 + label = pht('Jump to previous file.'); 91 91 + this._installJumpKey('K', label, -1, 'file'); 92 92 + 93 93 + label = pht('Jump to next inline comment.'); 94 94 + this._installJumpKey('n', label, 1, 'comment'); 95 95 + 96 96 + label = pht('Jump to previous inline comment.'); 97 97 + this._installJumpKey('p', label, -1, 'comment'); 98 98 + 99 99 + label = pht('Jump to the table of contents.'); 100 100 + this._installKey('t', label, this._ontoc); 67 101 }, 68 102 69 103 isAsleep: function() { ··· 130 164 if (routable) { 131 165 routable.setPriority(2000); 132 166 } 167 167 + }, 168 168 + 169 169 + _installKey: function(key, label, handler) { 170 170 + handler = JX.bind(this, this._ifawake, handler); 171 171 + 172 172 + return new JX.KeyboardShortcut(key, label) 173 173 + .setHandler(handler) 174 174 + .register(); 175 175 + }, 176 176 + 177 177 + _installJumpKey: function(key, label, delta, filter) { 178 178 + filter = filter || null; 179 179 + var handler = JX.bind(this, this._onjumpkey, delta, filter); 180 180 + return this._installKey(key, label, handler); 181 181 + }, 182 182 + 183 183 + _ontoc: function(manager) { 184 184 + var toc = JX.$('toc'); 185 185 + manager.scrollTo(toc); 186 186 + }, 187 187 + 188 188 + _onjumpkey: function(delta, filter, manager) { 189 189 + var state = this._getSelectionState(); 190 190 + 191 191 + var cursor = state.cursor; 192 192 + var items = state.items; 193 193 + 194 194 + // If there's currently no selection and the user tries to go back, 195 195 + // don't do anything. 196 196 + if ((cursor === null) && (delta < 0)) { 197 197 + return; 198 198 + } 199 199 + 200 200 + while (true) { 201 201 + if (cursor === null) { 202 202 + cursor = 0; 203 203 + } else { 204 204 + cursor = cursor + delta; 205 205 + } 206 206 + 207 207 + // If we've gone backward past the first change, bail out. 208 208 + if (cursor < 0) { 209 209 + return; 210 210 + } 211 211 + 212 212 + // If we've gone forward off the end of the list, bail out. 213 213 + if (cursor >= items.length) { 214 214 + return; 215 215 + } 216 216 + 217 217 + // If we're selecting things of a particular type (like only files) 218 218 + // and the next item isn't of that type, move past it. 219 219 + if (filter !== null) { 220 220 + if (items[cursor].type !== filter) { 221 221 + continue; 222 222 + } 223 223 + } 224 224 + 225 225 + // Otherwise, we've found a valid item to select. 226 226 + break; 227 227 + } 228 228 + 229 229 + this._setSelectionState(items[cursor], manager); 230 230 + }, 231 231 + 232 232 + _getSelectionState: function() { 233 233 + var items = this._getSelectableItems(); 234 234 + 235 235 + var cursor = null; 236 236 + if (this._cursorItem !== null) { 237 237 + for (var ii = 0; ii < items.length; ii++) { 238 238 + var item = items[ii]; 239 239 + if (this._cursorItem.target === item.target) { 240 240 + cursor = ii; 241 241 + break; 242 242 + } 243 243 + } 244 244 + } 245 245 + 246 246 + return { 247 247 + cursor: cursor, 248 248 + items: items 249 249 + }; 250 250 + }, 251 251 + 252 252 + _setSelectionState: function(item, manager) { 253 253 + this._cursorItem = item; 254 254 + 255 255 + this._redrawSelection(manager, true); 256 256 + 257 257 + return this; 258 258 + }, 259 259 + 260 260 + _redrawSelection: function(manager, scroll) { 261 261 + manager = manager || this._lastKeyboardManager; 262 262 + this._lastKeyboardManager = manager; 263 263 + 264 264 + if (this.isAsleep()) { 265 265 + manager.focusOn(null); 266 266 + return; 267 267 + } 268 268 + 269 269 + var cursor = this._cursorItem; 270 270 + if (!cursor) { 271 271 + manager.focusOn(null); 272 272 + return; 273 273 + } 274 274 + 275 275 + manager.focusOn(cursor.nodes.begin, cursor.nodes.end); 276 276 + 277 277 + if (scroll) { 278 278 + manager.scrollTo(cursor.nodes.begin); 279 279 + } 280 280 + 281 281 + return this; 282 282 + }, 283 283 + 284 284 + _getSelectableItems: function() { 285 285 + var result = []; 286 286 + 287 287 + for (var ii = 0; ii < this._changesets.length; ii++) { 288 288 + var items = this._changesets[ii].getSelectableItems(); 289 289 + for (var jj = 0; jj < items.length; jj++) { 290 290 + result.push(items[jj]); 291 291 + } 292 292 + } 293 293 + 294 294 + return result; 133 295 }, 134 296 135 297 _onmore: function(e) {

-264

webroot/rsrc/js/application/differential/behavior-keyboard-nav.js

reviewed

··· 1 1 - /** 2 2 - * @provides javelin-behavior-differential-keyboard-navigation 3 3 - * @requires javelin-behavior 4 4 - * javelin-dom 5 5 - * javelin-stratcom 6 6 - * phabricator-keyboard-shortcut 7 7 - */ 8 8 - 9 9 - JX.behavior('differential-keyboard-navigation', function(config) { 10 10 - 11 11 - var cursor = -1; 12 12 - var changesets; 13 13 - 14 14 - var selection_begin = null; 15 15 - var selection_end = null; 16 16 - 17 17 - var refreshFocus = function() {}; 18 18 - 19 19 - function init() { 20 20 - if (changesets) { 21 21 - return; 22 22 - } 23 23 - changesets = JX.DOM.scry(document.body, 'div', 'differential-changeset'); 24 24 - } 25 25 - 26 26 - function getBlocks(cursor) { 27 27 - // TODO: This might not be terribly fast; we can't currently memoize it 28 28 - // because it can change as ajax requests come in (e.g., content loads). 29 29 - 30 30 - var rows = JX.DOM.scry(changesets[cursor], 'tr'); 31 31 - var blocks = [[changesets[cursor], changesets[cursor]]]; 32 32 - var start = null; 33 33 - var type; 34 34 - var ii; 35 35 - 36 36 - // Don't show code blocks inside a collapsed file. 37 37 - var diff = JX.DOM.scry(changesets[cursor], 'table', 'differential-diff'); 38 38 - if (diff.length == 1 && JX.Stratcom.getData(diff[0]).hidden) { 39 39 - return blocks; 40 40 - } 41 41 - 42 42 - function push() { 43 43 - if (start) { 44 44 - blocks.push([start, rows[ii - 1]]); 45 45 - } 46 46 - start = null; 47 47 - } 48 48 - 49 49 - for (ii = 0; ii < rows.length; ii++) { 50 50 - type = getRowType(rows[ii]); 51 51 - if (type == 'comment') { 52 52 - // If we see these types of rows, make a block for each one. 53 53 - push(); 54 54 - } 55 55 - if (!type) { 56 56 - push(); 57 57 - } else if (type && !start) { 58 58 - start = rows[ii]; 59 59 - } 60 60 - } 61 61 - push(); 62 62 - 63 63 - return blocks; 64 64 - } 65 65 - 66 66 - function getRowType(row) { 67 67 - // NOTE: Being somewhat over-general here to allow other types of objects 68 68 - // to be easily focused in the future (inline comments, 'show more..'). 69 69 - 70 70 - if (row.className.indexOf('inline') !== -1) { 71 71 - return 'comment'; 72 72 - } 73 73 - 74 74 - if (row.className.indexOf('differential-changeset') !== -1) { 75 75 - return 'file'; 76 76 - } 77 77 - 78 78 - var cells = JX.DOM.scry(row, 'td'); 79 79 - 80 80 - for (var ii = 0; ii < cells.length; ii++) { 81 81 - // NOTE: The semantic use of classnames here is for performance; don't 82 82 - // emulate this elsewhere since it's super terrible. 83 83 - if (cells[ii].className.indexOf('old') !== -1 || 84 84 - cells[ii].className.indexOf('new') !== -1) { 85 85 - return 'change'; 86 86 - } 87 87 - } 88 88 - 89 89 - return null; 90 90 - } 91 91 - 92 92 - function jump(manager, delta, jump_to_type) { 93 93 - init(); 94 94 - 95 95 - if (cursor < 0) { 96 96 - if (delta < 0) { 97 97 - // If the user goes "back" without a selection, just reject the action. 98 98 - return; 99 99 - } else { 100 100 - cursor = 0; 101 101 - } 102 102 - } 103 103 - 104 104 - while (true) { 105 105 - var blocks = getBlocks(cursor); 106 106 - var focus; 107 107 - if (delta < 0) { 108 108 - focus = blocks.length; 109 109 - } else { 110 110 - focus = -1; 111 111 - } 112 112 - 113 113 - for (var ii = 0; ii < blocks.length; ii++) { 114 114 - if (blocks[ii][0] == selection_begin) { 115 115 - focus = ii; 116 116 - break; 117 117 - } 118 118 - } 119 119 - 120 120 - while (true) { 121 121 - focus += delta; 122 122 - 123 123 - if (blocks[focus]) { 124 124 - var row_type = getRowType(blocks[focus][0]); 125 125 - if (jump_to_type && row_type != jump_to_type) { 126 126 - continue; 127 127 - } 128 128 - 129 129 - selection_begin = blocks[focus][0]; 130 130 - selection_end = blocks[focus][1]; 131 131 - 132 132 - manager.scrollTo(selection_begin); 133 133 - 134 134 - refreshFocus = function() { 135 135 - manager.focusOn(selection_begin, selection_end); 136 136 - }; 137 137 - 138 138 - refreshFocus(); 139 139 - 140 140 - return; 141 141 - } else { 142 142 - var adjusted = (cursor + delta); 143 143 - if (adjusted < 0 || adjusted >= changesets.length) { 144 144 - // Stop cursor movement when the user reaches either end. 145 145 - return; 146 146 - } 147 147 - cursor = adjusted; 148 148 - 149 149 - // Break the inner loop and go to the next file. 150 150 - break; 151 151 - } 152 152 - } 153 153 - } 154 154 - 155 155 - } 156 156 - 157 157 - // When inline comments are updated, wipe out our cache of blocks since 158 158 - // comments may have been added or deleted. 159 159 - JX.Stratcom.listen( 160 160 - null, 161 161 - 'differential-inline-comment-update', 162 162 - function() { 163 163 - changesets = null; 164 164 - }); 165 165 - // Same thing when a file is hidden or shown; don't want to highlight 166 166 - // invisible code. 167 167 - JX.Stratcom.listen( 168 168 - 'differential-toggle-file-toggled', 169 169 - null, 170 170 - function() { 171 171 - changesets = null; 172 172 - init(); 173 173 - refreshFocus(); 174 174 - }); 175 175 - 176 176 - new JX.KeyboardShortcut('j', 'Jump to next change.') 177 177 - .setHandler(function(manager) { 178 178 - jump(manager, 1); 179 179 - }) 180 180 - .register(); 181 181 - 182 182 - new JX.KeyboardShortcut('k', 'Jump to previous change.') 183 183 - .setHandler(function(manager) { 184 184 - jump(manager, -1); 185 185 - }) 186 186 - .register(); 187 187 - 188 188 - new JX.KeyboardShortcut('J', 'Jump to next file.') 189 189 - .setHandler(function(manager) { 190 190 - jump(manager, 1, 'file'); 191 191 - }) 192 192 - .register(); 193 193 - 194 194 - new JX.KeyboardShortcut('K', 'Jump to previous file.') 195 195 - .setHandler(function(manager) { 196 196 - jump(manager, -1, 'file'); 197 197 - }) 198 198 - .register(); 199 199 - 200 200 - new JX.KeyboardShortcut('n', 'Jump to next inline comment.') 201 201 - .setHandler(function(manager) { 202 202 - jump(manager, 1, 'comment'); 203 203 - }) 204 204 - .register(); 205 205 - 206 206 - new JX.KeyboardShortcut('p', 'Jump to previous inline comment.') 207 207 - .setHandler(function(manager) { 208 208 - jump(manager, -1, 'comment'); 209 209 - }) 210 210 - .register(); 211 211 - 212 212 - 213 213 - new JX.KeyboardShortcut('t', 'Jump to the table of contents.') 214 214 - .setHandler(function(manager) { 215 215 - var toc = JX.$('toc'); 216 216 - manager.scrollTo(toc); 217 217 - }) 218 218 - .register(); 219 219 - 220 220 - new JX.KeyboardShortcut( 221 221 - 'h', 222 222 - 'Collapse or expand the file display (after jump).') 223 223 - .setHandler(function() { 224 224 - if (!changesets || !changesets[cursor]) { 225 225 - return; 226 226 - } 227 227 - JX.Stratcom.invoke('differential-toggle-file', null, { 228 228 - diff: JX.DOM.scry(changesets[cursor], 'table', 'differential-diff') 229 229 - }); 230 230 - }) 231 231 - .register(); 232 232 - 233 233 - 234 234 - function inline_op(node, op) { 235 235 - // nothing selected 236 236 - if (!node) { 237 237 - return; 238 238 - } 239 239 - if (!JX.DOM.scry(node, 'a', 'differential-inline-' + op)) { 240 240 - // No link for this operation, e.g. editing a comment you can't edit. 241 241 - return; 242 242 - } 243 243 - 244 244 - var data = { 245 245 - node: JX.DOM.find(node, 'div', 'differential-inline-comment'), 246 246 - op: op 247 247 - }; 248 248 - 249 249 - JX.Stratcom.invoke('differential-inline-action', null, data); 250 250 - } 251 251 - 252 252 - new JX.KeyboardShortcut('r', 'Reply to selected inline comment.') 253 253 - .setHandler(function() { 254 254 - inline_op(selection_begin, 'reply'); 255 255 - }) 256 256 - .register(); 257 257 - 258 258 - new JX.KeyboardShortcut('e', 'Edit selected inline comment.') 259 259 - .setHandler(function() { 260 260 - inline_op(selection_begin, 'edit'); 261 261 - }) 262 262 - .register(); 263 263 - 264 264 - });