@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Show applications and icons for PHID types in config table
Summary: Ref T9625. Some PHID types are missing application or icon specifications. This makes it easier to spot them.
Test Plan: {F906321}
Reviewers: chad
Reviewed By: chad
Maniphest Tasks: T9625
Differential Revision: https://secure.phabricator.com/D14323
+32
+32
src/applications/config/module/PhabricatorConfigPHIDModule.php
+32
src/applications/config/module/PhabricatorConfigPHIDModule.php
···
18
18
19
19
$rows = array();
20
20
foreach ($types as $key => $type) {
21
+
$class_name = $type->getPHIDTypeApplicationClass();
22
+
if ($class_name !== null) {
23
+
$app = PhabricatorApplication::getByClass($class_name);
24
+
$app_name = $app->getName();
25
+
26
+
$icon = $app->getFontIcon();
27
+
if ($icon) {
28
+
$app_icon = id(new PHUIIconView())->setIconFont($icon);
29
+
} else {
30
+
$app_icon = null;
31
+
}
32
+
} else {
33
+
$app_name = null;
34
+
$app_icon = null;
35
+
}
36
+
37
+
$icon = $type->getTypeIcon();
38
+
if ($icon) {
39
+
$type_icon = id(new PHUIIconView())->setIconFont($icon);
40
+
} else {
41
+
$type_icon = null;
42
+
}
43
+
21
44
$rows[] = array(
22
45
$type->getTypeConstant(),
23
46
get_class($type),
47
+
$app_icon,
48
+
$app_name,
49
+
$type_icon,
24
50
$type->getTypeName(),
25
51
);
26
52
}
···
30
56
array(
31
57
pht('Constant'),
32
58
pht('Class'),
59
+
null,
60
+
pht('Application'),
61
+
null,
33
62
pht('Name'),
34
63
))
35
64
->setColumnClasses(
36
65
array(
37
66
null,
38
67
'pri',
68
+
'icon',
69
+
null,
70
+
'icon',
39
71
'wide',
40
72
));
41
73