@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Make View Revision in Mail a little more resilient
Summary: Converts to table so text wraps on long strings well, button always stays top right, better spacing underneath.
Test Plan: Mail, Gmail, mobile
Reviewers: epriestley
Reviewed By: epriestley
Subscribers: Korvin
Differential Revision: https://secure.phabricator.com/D15955
+12
-16
+12
-16
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+12
-16
src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
···
2730
2730
$button_style = array(
2731
2731
'text-decoration: none;',
2732
2732
'padding: 4px 8px;',
2733
-
'margin: 0 8px;',
2733
+
'margin: 0 8px 8px;',
2734
2734
'float: right;',
2735
2735
'color: #464C5C;',
2736
2736
'font-weight: bold;',
2737
2737
'border-radius: 3px;',
2738
2738
'background-color: #F7F7F9;',
2739
2739
'background-image: linear-gradient(to bottom,#fff,#f1f0f1);',
2740
+
'display: inline-block;',
2740
2741
'border: 1px solid rgba(71,87,120,.2);',
2741
2742
);
2742
2743
···
2750
2751
}
2751
2752
2752
2753
$xactions_style = array(
2753
-
'padding: 0 0 8px 0;',
2754
2754
);
2755
2755
2756
-
$headers_html = phutil_tag(
2757
-
'div',
2756
+
$header_action = phutil_tag(
2757
+
'td',
2758
+
array(),
2759
+
$header_button);
2760
+
2761
+
$header_action = phutil_tag(
2762
+
'td',
2758
2763
array(
2759
2764
'style' => implode(' ', $xactions_style),
2760
2765
),
2761
2766
$headers_html);
2762
2767
2763
-
$header_style = array(
2764
-
'overflow: hidden;',
2765
-
);
2766
-
2767
2768
$headers_html = phutil_tag(
2768
-
'div',
2769
-
array(
2770
-
'style' => implode(' ', $header_style),
2771
-
),
2772
-
array(
2773
-
$header_button,
2774
-
$headers_html,
2775
-
));
2769
+
'table',
2770
+
array(),
2771
+
phutil_tag('tr', array(), array($header_action, $header_button)));
2776
2772
2777
2773
$body->addRawHTMLSection($headers_html);
2778
2774