@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Propagate the "ContextObject" to Remarkup rendering in timelines
Summary:
Ref T13602. Currently, timeline comment rendering does not (by default) propagate the context object to the rendering layer.
This means that `@mentions` of users who can't see the object aren't rendered properly (currently: they show up as blue, but should show up as grey).
Pass the context down the stack and into the remarkup engine.
Test Plan: {F8382905}
Maniphest Tasks: T13602
Differential Revision: https://secure.phabricator.com/D21548
+18
+1
src/applications/transactions/engine/PhabricatorTimelineEngine.php
+1
src/applications/transactions/engine/PhabricatorTimelineEngine.php
+17
src/applications/transactions/view/PhabricatorApplicationTransactionView.php
+17
src/applications/transactions/view/PhabricatorApplicationTransactionView.php
···
9
9
private $engine;
10
10
private $showEditActions = true;
11
11
private $isPreview;
12
+
private $object;
12
13
private $objectPHID;
13
14
private $shouldTerminate = false;
14
15
private $quoteTargetID;
···
39
40
40
41
public function getQuoteTargetID() {
41
42
return $this->quoteTargetID;
43
+
}
44
+
45
+
public function setObject(
46
+
PhabricatorApplicationTransactionInterface $object) {
47
+
$this->object = $object;
48
+
return $this;
49
+
}
50
+
51
+
private function getObject() {
52
+
return $this->object;
42
53
}
43
54
44
55
public function setObjectPHID($object_phid) {
···
238
249
239
250
$engine = id(new PhabricatorMarkupEngine())
240
251
->setViewer($this->getViewer());
252
+
253
+
$object = $this->getObject();
254
+
if ($object) {
255
+
$engine->setContextObject($object);
256
+
}
257
+
241
258
foreach ($this->transactions as $xaction) {
242
259
if (!$xaction->hasComment()) {
243
260
continue;