@recaptime-dev's working patches + fork for Phorge, a community fork of Phabricator. (Upstream dev and stable branches are at upstream/main and upstream/stable respectively.)
hq.recaptime.dev/wiki/Phorge
phorge
phabricator
Hash Diffusion README cachekey components
Without this, we end up with an overlong cache key in some cases.
Auditors: chad
+5
-2
+5
-2
src/applications/diffusion/controller/DiffusionController.php
+5
-2
src/applications/diffusion/controller/DiffusionController.php
···
344
344
$repository_phid = $repository->getPHID();
345
345
$stable_commit = $drequest->getStableCommit();
346
346
347
+
$stable_commit_hash = PhabricatorHash::digestForIndex($stable_commit);
348
+
$readme_path_hash = PhabricatorHash::digestForindex($readme_path);
349
+
347
350
$cache = PhabricatorCaches::getMutableStructureCache();
348
351
$cache_key = "diffusion".
349
352
".repository({$repository_phid})".
350
-
".commit({$stable_commit})".
351
-
".readme({$readme_path})";
353
+
".commit({$stable_commit_hash})".
354
+
".readme({$readme_path_hash})";
352
355
353
356
$readme_cache = $cache->getKey($cache_key);
354
357
if (!$readme_cache) {